From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:44174) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RyMSx-0000El-4S for qemu-devel@nongnu.org; Fri, 17 Feb 2012 06:59:08 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RyMSr-00046d-32 for qemu-devel@nongnu.org; Fri, 17 Feb 2012 06:59:07 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43059) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RyMSq-00044d-OA for qemu-devel@nongnu.org; Fri, 17 Feb 2012 06:59:01 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1HBwxDN023220 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 17 Feb 2012 06:59:00 -0500 Date: Fri, 17 Feb 2012 09:58:59 -0200 From: Luiz Capitulino Message-ID: <20120217095859.5e3f213d@doriath.home> In-Reply-To: <4F3E30B1.9000101@redhat.com> References: <1329331347-11232-1-git-send-email-lcapitulino@redhat.com> <4F3E30B1.9000101@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/4]: QMP: add BLOCK_MEDIUM_EJECT event List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, eblake@redhat.com, qemu-devel@nongnu.org, armbru@redhat.com On Fri, 17 Feb 2012 11:49:21 +0100 Paolo Bonzini wrote: > On 02/15/2012 07:42 PM, Luiz Capitulino wrote: > > There's been one non-rfc patch and one or two rfc ones. This is v2 of the > > non-rfc one. > > > > I think this version does what Kevin and Markus were asking: the event is > > emitted whenever the tray moves, be it the guest or HMP/QMP commands. > > > > In a previous email I said that I'd be reviving an old series that breaks the > > eject and change commands into multiple tray commands (tray-open/close, > > medium-insert/remove etc), but that's not so trivial anymore as the tray state > > moved to device models (still possible of course, but requires a bit more > > work). So I decided to do it the way patch 4/4 does it. > > > > QMP/qmp-events.txt | 17 ++++++++++ > > block.c | 84 +++++++++++++++++++++++++++++++++------------------ > > block.h | 8 ++-- > > block/raw-posix.c | 6 ++-- > > block/raw.c | 4 +- > > block_int.h | 2 +- > > hw/ide/atapi.c | 2 +- > > hw/ide/core.c | 8 ++-- > > hw/scsi-disk.c | 8 ++-- > > hw/virtio-blk.c | 6 ++-- > > monitor.c | 3 ++ > > monitor.h | 1 + > > 12 files changed, 97 insertions(+), 52 deletions(-) > > We can seek perfection, but we can also do that incrementally. We're > discussing the code more than the actual behavior, so > > Acked-by: Paolo Bonzini I'll submit v3 with a few renames and the change proposed by Markus, which is not to call bdrv_eject() in the device models if the tray didn't move.