From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:33426) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RyRgw-00033J-B6 for qemu-devel@nongnu.org; Fri, 17 Feb 2012 12:33:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RyRgu-0002iS-Bd for qemu-devel@nongnu.org; Fri, 17 Feb 2012 12:33:54 -0500 Received: from mx1.redhat.com ([209.132.183.28]:20516) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RyRgt-0002hp-VC for qemu-devel@nongnu.org; Fri, 17 Feb 2012 12:33:52 -0500 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1HHXpeF009597 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 17 Feb 2012 12:33:51 -0500 Date: Fri, 17 Feb 2012 15:33:51 -0200 From: Luiz Capitulino Message-ID: <20120217153351.6416e5c5@doriath.home> In-Reply-To: <1329301701-30395-13-git-send-email-kraxel@redhat.com> References: <1329301701-30395-1-git-send-email-kraxel@redhat.com> <1329301701-30395-13-git-send-email-kraxel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 12/12] suspend: add qmp events List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org On Wed, 15 Feb 2012 11:28:21 +0100 Gerd Hoffmann wrote: > Send qmp events on suspend and wakeup so libvirt > has a chance to track the vm state. > > Signed-off-by: Gerd Hoffmann > --- > monitor.c | 6 ++++++ > monitor.h | 2 ++ > vl.c | 15 +++++++++++++++ > 3 files changed, 23 insertions(+), 0 deletions(-) > > diff --git a/monitor.c b/monitor.c > index aadbdcb..e6f5fad 100644 > --- a/monitor.c > +++ b/monitor.c > @@ -485,6 +485,12 @@ void monitor_protocol_event(MonitorEvent event, QObject *data) > case QEVENT_BLOCK_JOB_CANCELLED: > event_name = "BLOCK_JOB_CANCELLED"; > break; > + case QEVENT_SUSPEND: > + event_name = "SUSPEND"; > + break; > + case QEVENT_WAKEUP: > + event_name = "WAKEUP"; > + break; > default: > abort(); > break; > diff --git a/monitor.h b/monitor.h > index b72ea07..9df3bab 100644 > --- a/monitor.h > +++ b/monitor.h > @@ -38,6 +38,8 @@ typedef enum MonitorEvent { > QEVENT_SPICE_DISCONNECTED, > QEVENT_BLOCK_JOB_COMPLETED, > QEVENT_BLOCK_JOB_CANCELLED, > + QEVENT_SUSPEND, > + QEVENT_WAKEUP, > QEVENT_MAX, > } MonitorEvent; > > diff --git a/vl.c b/vl.c > index bfdcb7c..570ea05 100644 > --- a/vl.c > +++ b/vl.c > @@ -1416,6 +1416,7 @@ static void qemu_system_suspend(void) > { > pause_all_vcpus(); > notifier_list_notify(&suspend_notifiers, NULL); > + monitor_protocol_event(QEVENT_SUSPEND, NULL); > is_suspended = true; > } > > @@ -1436,12 +1437,26 @@ void qemu_register_suspend_notifier(Notifier *notifier) > > void qemu_system_wakeup_request(WakeupReason reason) > { > + static const char *names[] = { > + [QEMU_WAKEUP_REASON_OTHER] = "other", > + [QEMU_WAKEUP_REASON_RTC] = "rtc", > + [QEMU_WAKEUP_REASON_PMTIMER] = "pmtimer", Is the reason really important for mngt? Can we just leave it out? > + }; > + const char *name; > + QObject *data; > + > if (!is_suspended) { > return; > } > if (!(wakeup_reason_mask & (1 << reason))) { > return; > } > + > + name = (reason < ARRAY_SIZE(names)) ? names[reason] : "unknown"; > + data = qobject_from_jsonf("{ 'reason': %s }", name); > + monitor_protocol_event(QEVENT_WAKEUP, data); > + qobject_decref(data); > + > notifier_list_notify(&wakeup_notifiers, &reason); > reset_requested = 1; > qemu_notify_event();