From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:57194)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1RyTBO-0005Hs-EW
	for qemu-devel@nongnu.org; Fri, 17 Feb 2012 14:09:27 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1RyTBN-0004Rr-Fm
	for qemu-devel@nongnu.org; Fri, 17 Feb 2012 14:09:26 -0500
Received: from mx1.redhat.com ([209.132.183.28]:5214)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1RyTBN-0004Rm-7g
	for qemu-devel@nongnu.org; Fri, 17 Feb 2012 14:09:25 -0500
Date: Fri, 17 Feb 2012 21:09:11 +0200
From: Alon Levy <alevy@redhat.com>
Message-ID: <20120217190911.GN16163@garlic.redhat.com>
References: <1329433888-17678-1-git-send-email-alevy@redhat.com>
	<1329468300-6507-1-git-send-email-alevy@redhat.com>
	<CAJ+F1CLmM7PdeSe4zQEOFvXV-hQV-s3bd_BGe3Dj1Au3ypE2xA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <CAJ+F1CLmM7PdeSe4zQEOFvXV-hQV-s3bd_BGe3Dj1Au3ypE2xA@mail.gmail.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2 1/2] qxl: introduce QXLCookie
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?iso-8859-1?Q?Marc-Andr=E9?= Lureau <marcandre.lureau@gmail.com>
Cc: qemu-devel@nongnu.org, elmarco@redhat.com, kraxel@redhat.com

On Fri, Feb 17, 2012 at 01:49:20PM +0100, Marc-Andr=E9 Lureau wrote:
> Hi
>=20
> On Fri, Feb 17, 2012 at 9:44 AM, Alon Levy <alevy@redhat.com> wrote:
> > +/* called from spice server thread context only */
> > +static void interface_async_complete(QXLInstance *sin, uint64_t cook=
ie_token)
> > +{
> > + =A0 =A0PCIQXLDevice *qxl =3D container_of(sin, PCIQXLDevice, ssd.qx=
l);
> > + =A0 =A0QXLCookie *cookie =3D (QXLCookie*)cookie_token;
> > +
> > + =A0 =A0switch (cookie->type) {
>=20
> We still have spice_qxl_flush_surfaces_async(&qxl->ssd.qxl, 0);
>=20
> So cookie might be NULL in this case.

Yeah, Marc Andre also noticed (exprimentally - you take the cake on the
review :).

>=20
> --=20
> Marc-Andr=E9 Lureau