From: Alon Levy <alevy@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] hw/qxl: allow vram to be sized to 4096 bytes
Date: Fri, 17 Feb 2012 21:15:57 +0200 [thread overview]
Message-ID: <20120217191557.GA23926@garlic.redhat.com> (raw)
In-Reply-To: <4F3E6E3F.4070300@redhat.com>
On Fri, Feb 17, 2012 at 04:11:59PM +0100, Gerd Hoffmann wrote:
> Hi,
>
> > - if (qxl->vram_size < 16 * 1024 * 1024) {
> > + /* a request of 0 vram_size is translated to the smallest vram that doesn't
> > + * break current off screen surfaces using drivers */
> > + if (qxl->vram_size > 0 && qxl->vram_size < 16 * 1024 * 1024) {
>
> Is there any reason to keep the 16MB minimum size? I think we can just
> drop it and simplify the logic here. See the patch series just sent.
I agree. Will review your patchset.
>
> cheers,
> Gerd
>
next prev parent reply other threads:[~2012-02-17 19:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-16 17:45 [Qemu-devel] [PATCH] hw/qxl: allow vram to be sized to 4096 bytes Alon Levy
2012-02-17 15:11 ` Gerd Hoffmann
2012-02-17 19:15 ` Alon Levy [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-11-09 13:37 Alon Levy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120217191557.GA23926@garlic.redhat.com \
--to=alevy@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).