From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:46477) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RyTU1-0007Uw-LZ for qemu-devel@nongnu.org; Fri, 17 Feb 2012 14:28:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RyTU0-0007Yo-I9 for qemu-devel@nongnu.org; Fri, 17 Feb 2012 14:28:41 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49493) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RyTU0-0007Ye-Ae for qemu-devel@nongnu.org; Fri, 17 Feb 2012 14:28:40 -0500 Date: Fri, 17 Feb 2012 21:28:33 +0200 From: Alon Levy Message-ID: <20120217192833.GF23926@garlic.redhat.com> References: <1329491433-31446-1-git-send-email-kraxel@redhat.com> <1329491433-31446-2-git-send-email-kraxel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1329491433-31446-2-git-send-email-kraxel@redhat.com> Subject: Re: [Qemu-devel] [PATCH 1/4] qxl: drop vram bar minimum size List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: spice-devel@lists.freedesktop.org, qemu-devel@nongnu.org On Fri, Feb 17, 2012 at 04:10:30PM +0100, Gerd Hoffmann wrote: > There is no reason to require a minimum size of 16 MB for the vram. > Lower the limit to 4096 (one page). Make it disapper completely would > break guests. NM my nitpick, more readable this way, ACK. > --- > hw/qxl.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/qxl.c b/hw/qxl.c > index 5c6b556..4de4b8d 100644 > --- a/hw/qxl.c > +++ b/hw/qxl.c > @@ -1592,8 +1592,8 @@ static int qxl_init_common(PCIQXLDevice *qxl) > init_qxl_rom(qxl); > init_qxl_ram(qxl); > > - if (qxl->vram_size < 16 * 1024 * 1024) { > - qxl->vram_size = 16 * 1024 * 1024; > + if (qxl->vram_size < 4096) { > + qxl->vram_size = 4096; > } > if (qxl->revision == 1) { > qxl->vram_size = 4096; > -- > 1.7.1 > >