From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:35001) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rz8CK-0000KQ-NV for qemu-devel@nongnu.org; Sun, 19 Feb 2012 09:57:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rz8CJ-0005NI-IL for qemu-devel@nongnu.org; Sun, 19 Feb 2012 09:57:08 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39429) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rz8CJ-0005ND-Bd for qemu-devel@nongnu.org; Sun, 19 Feb 2012 09:57:07 -0500 Date: Sun, 19 Feb 2012 16:57:07 +0200 From: "Michael S. Tsirkin" Message-ID: <20120219145707.GC16620@redhat.com> References: <4F3E5564.7040406@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F3E5564.7040406@redhat.com> Subject: Re: [Qemu-devel] [PATCHv2-RFC 2/2] pci: add standard bridge device List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: Kevin Wolf , Isaku Yamahata , qemu-devel@nongnu.org, kvm@vger.kernel.org, Avi Kivity On Fri, Feb 17, 2012 at 02:25:56PM +0100, Gerd Hoffmann wrote: > Hi, > > > + /* If we don't specify the name, the bus will be addressed as .0, where > > + * id is the parent id. But it seems more natural to address the bus using > > + * the parent device name. */ > > + if (dev->qdev.id && *dev->qdev.id) { > > + br->bus_name = dev->qdev.id; > > + } > > That makes the bridge behave different than everybody else. > Not a good idea IMHO. > > cheers, > Gerd Everybody else has names built up according to an undocumented scheme which no one can figure out without reading code, so no one uses them. We need to fix that, but there is, generally, no need for these names so it stayed low priority. With the bridge people must use the id to connect devices to it, so name must be a sane one. -- MST