From: "Justin M. Forbes" <jforbes@redhat.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: Kenneth Salerno <kennethsalerno@yahoo.com>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [patch] qemu-1.0.1/VERSION
Date: Sun, 19 Feb 2012 16:26:14 -0600 [thread overview]
Message-ID: <20120219222614.GA26687@redhat.com> (raw)
In-Reply-To: <4F40D42D.4020608@weilnetz.de>
On Sun, Feb 19, 2012 at 11:51:25AM +0100, Stefan Weil wrote:
> Am 19.02.2012 01:05, schrieb Kenneth Salerno:
> >Hello,
> >
> >The VERSION file in stable release qemu-1.0.1 has what I believe might be a typo: "1.0,1" rather than "1.0.1". This is causing a parsing issue for windres.exe in Win32 which chokes on:
> > #define CONFIG_FILEVERSION 1,0,1,0,1,0
> > #define CONFIG_PRODUCTVERSION 1,0,1,0,1,0
> >
> >when it should be seeing this:
> > #define CONFIG_FILEVERSION 1,0,1,0
> > #define CONFIG_PRODUCTVERSION 1,0,1,0
> >
> >
> >Patch:
> >--- VERSION.ORIG 2012-02-18 18:56:16.625000000 -0500
> >+++ VERSION 2012-02-18 18:56:31.609375000 -0500
> >@@ -1 +1 @@
> >-1.0,1
> >+1.0.1
>
> Acked-by: Stefan Weil <sw@weilnetz.de>
Ack, wow do I feel silly. Thanks for the catch.
--
Justin M. Forbes
prev parent reply other threads:[~2012-02-19 22:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-19 0:05 [Qemu-devel] [patch] qemu-1.0.1/VERSION Kenneth Salerno
2012-02-19 10:51 ` Stefan Weil
2012-02-19 22:26 ` Justin M. Forbes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120219222614.GA26687@redhat.com \
--to=jforbes@redhat.com \
--cc=kennethsalerno@yahoo.com \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).