* [Qemu-devel] [patch] qemu-1.0.1/VERSION
@ 2012-02-19 0:05 Kenneth Salerno
2012-02-19 10:51 ` Stefan Weil
0 siblings, 1 reply; 3+ messages in thread
From: Kenneth Salerno @ 2012-02-19 0:05 UTC (permalink / raw)
To: qemu-devel
Hello,
The VERSION file in stable release qemu-1.0.1 has what I believe might be a typo: "1.0,1" rather than "1.0.1". This is causing a parsing issue for windres.exe in Win32 which chokes on:
#define CONFIG_FILEVERSION 1,0,1,0,1,0
#define CONFIG_PRODUCTVERSION 1,0,1,0,1,0
when it should be seeing this:
#define CONFIG_FILEVERSION 1,0,1,0
#define CONFIG_PRODUCTVERSION 1,0,1,0
Patch:
--- VERSION.ORIG 2012-02-18 18:56:16.625000000 -0500
+++ VERSION 2012-02-18 18:56:31.609375000 -0500
@@ -1 +1 @@
-1.0,1
+1.0.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [patch] qemu-1.0.1/VERSION
2012-02-19 0:05 [Qemu-devel] [patch] qemu-1.0.1/VERSION Kenneth Salerno
@ 2012-02-19 10:51 ` Stefan Weil
2012-02-19 22:26 ` Justin M. Forbes
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Weil @ 2012-02-19 10:51 UTC (permalink / raw)
To: Justin M. Forbes; +Cc: Kenneth Salerno, qemu-devel
Am 19.02.2012 01:05, schrieb Kenneth Salerno:
> Hello,
>
> The VERSION file in stable release qemu-1.0.1 has what I believe might be a typo: "1.0,1" rather than "1.0.1". This is causing a parsing issue for windres.exe in Win32 which chokes on:
> #define CONFIG_FILEVERSION 1,0,1,0,1,0
> #define CONFIG_PRODUCTVERSION 1,0,1,0,1,0
>
> when it should be seeing this:
> #define CONFIG_FILEVERSION 1,0,1,0
> #define CONFIG_PRODUCTVERSION 1,0,1,0
>
>
> Patch:
> --- VERSION.ORIG 2012-02-18 18:56:16.625000000 -0500
> +++ VERSION 2012-02-18 18:56:31.609375000 -0500
> @@ -1 +1 @@
> -1.0,1
> +1.0.1
Acked-by: Stefan Weil <sw@weilnetz.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [patch] qemu-1.0.1/VERSION
2012-02-19 10:51 ` Stefan Weil
@ 2012-02-19 22:26 ` Justin M. Forbes
0 siblings, 0 replies; 3+ messages in thread
From: Justin M. Forbes @ 2012-02-19 22:26 UTC (permalink / raw)
To: Stefan Weil; +Cc: Kenneth Salerno, qemu-devel
On Sun, Feb 19, 2012 at 11:51:25AM +0100, Stefan Weil wrote:
> Am 19.02.2012 01:05, schrieb Kenneth Salerno:
> >Hello,
> >
> >The VERSION file in stable release qemu-1.0.1 has what I believe might be a typo: "1.0,1" rather than "1.0.1". This is causing a parsing issue for windres.exe in Win32 which chokes on:
> > #define CONFIG_FILEVERSION 1,0,1,0,1,0
> > #define CONFIG_PRODUCTVERSION 1,0,1,0,1,0
> >
> >when it should be seeing this:
> > #define CONFIG_FILEVERSION 1,0,1,0
> > #define CONFIG_PRODUCTVERSION 1,0,1,0
> >
> >
> >Patch:
> >--- VERSION.ORIG 2012-02-18 18:56:16.625000000 -0500
> >+++ VERSION 2012-02-18 18:56:31.609375000 -0500
> >@@ -1 +1 @@
> >-1.0,1
> >+1.0.1
>
> Acked-by: Stefan Weil <sw@weilnetz.de>
Ack, wow do I feel silly. Thanks for the catch.
--
Justin M. Forbes
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-02-19 22:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-19 0:05 [Qemu-devel] [patch] qemu-1.0.1/VERSION Kenneth Salerno
2012-02-19 10:51 ` Stefan Weil
2012-02-19 22:26 ` Justin M. Forbes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).