From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:48043)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jforbes@redhat.com>) id 1RzFD3-0001p8-5n
	for qemu-devel@nongnu.org; Sun, 19 Feb 2012 17:26:22 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jforbes@redhat.com>) id 1RzFD2-0005O8-40
	for qemu-devel@nongnu.org; Sun, 19 Feb 2012 17:26:21 -0500
Received: from mx1.redhat.com ([209.132.183.28]:39204)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jforbes@redhat.com>) id 1RzFD1-0005Nv-Td
	for qemu-devel@nongnu.org; Sun, 19 Feb 2012 17:26:20 -0500
Date: Sun, 19 Feb 2012 16:26:14 -0600
From: "Justin M. Forbes" <jforbes@redhat.com>
Message-ID: <20120219222614.GA26687@redhat.com>
References: <1329609944.90569.YahooMailClassic@web110415.mail.gq1.yahoo.com>
	<4F40D42D.4020608@weilnetz.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4F40D42D.4020608@weilnetz.de>
Subject: Re: [Qemu-devel] [patch] qemu-1.0.1/VERSION
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <sw@weilnetz.de>
Cc: Kenneth Salerno <kennethsalerno@yahoo.com>, qemu-devel@nongnu.org

On Sun, Feb 19, 2012 at 11:51:25AM +0100, Stefan Weil wrote:
> Am 19.02.2012 01:05, schrieb Kenneth Salerno:
> >Hello,
> >
> >The VERSION file in stable release qemu-1.0.1 has what I believe might be a typo: "1.0,1" rather than "1.0.1". This is causing a parsing issue for windres.exe in Win32 which chokes on:
> >    #define CONFIG_FILEVERSION 1,0,1,0,1,0
> >    #define CONFIG_PRODUCTVERSION 1,0,1,0,1,0
> >
> >when it should be seeing this:
> >    #define CONFIG_FILEVERSION 1,0,1,0
> >    #define CONFIG_PRODUCTVERSION 1,0,1,0
> >
> >
> >Patch:
> >--- VERSION.ORIG        2012-02-18 18:56:16.625000000 -0500
> >+++ VERSION     2012-02-18 18:56:31.609375000 -0500
> >@@ -1 +1 @@
> >-1.0,1
> >+1.0.1
> 
> Acked-by: Stefan Weil <sw@weilnetz.de>

Ack, wow do I feel silly.  Thanks for the catch.
-- 
Justin M. Forbes