From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:53891)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1RzGQi-00084v-4i
	for qemu-devel@nongnu.org; Sun, 19 Feb 2012 18:44:33 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1RzGQh-0000ag-7j
	for qemu-devel@nongnu.org; Sun, 19 Feb 2012 18:44:32 -0500
Received: from mx1.redhat.com ([209.132.183.28]:20599)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1RzGQh-0000ab-19
	for qemu-devel@nongnu.org; Sun, 19 Feb 2012 18:44:31 -0500
Date: Mon, 20 Feb 2012 01:44:34 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20120219234433.GA29703@redhat.com>
References: <cover.1329124507.git.mst@redhat.com>
	<f9b630bb6c67f0facf29e42277ad7d991e660b3c.1329124507.git.mst@redhat.com>
	<4F3E5564.7040406@redhat.com> <20120219145707.GC16620@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20120219145707.GC16620@redhat.com>
Subject: Re: [Qemu-devel] [PATCHv2-RFC 2/2] pci: add standard bridge device
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Isaku Yamahata <yamahata@valinux.co.jp>, qemu-devel@nongnu.org, kvm@vger.kernel.org, Avi Kivity <avi@redhat.com>

On Sun, Feb 19, 2012 at 04:57:07PM +0200, Michael S. Tsirkin wrote:
> On Fri, Feb 17, 2012 at 02:25:56PM +0100, Gerd Hoffmann wrote:
> >   Hi,
> > 
> > > +    /* If we don't specify the name, the bus will be addressed as <id>.0, where
> > > +     * id is the parent id.  But it seems more natural to address the bus using
> > > +     * the parent device name. */
> > > +    if (dev->qdev.id && *dev->qdev.id) {
> > > +        br->bus_name = dev->qdev.id;
> > > +    }
> > 
> > That makes the bridge behave different than everybody else.
> > Not a good idea IMHO.
> > 
> > cheers,
> >   Gerd
> 
> Everybody else has names built up according to an undocumented scheme
> which no one can figure out without reading code, so no one uses them.
> We need to fix that, but there is, generally, no need for these names
> so it stayed low priority.
> 
> With the bridge people must use the id to connect devices to it,
> so name must be a sane one.

I just sent the patch making bus id for bridges
follow the value set by the user.
That will make the bridge behave in the same way
as everybody else :)

> -- 
> MST