From: Alon Levy <alevy@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: spice-devel@lists.freedesktop.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Spice-devel] [PATCH 4/4] [experimental] add optinal 64bit vram bar to qxl
Date: Mon, 20 Feb 2012 10:19:00 +0200 [thread overview]
Message-ID: <20120220081900.GV23926@garlic.redhat.com> (raw)
In-Reply-To: <4F41FD8E.60406@redhat.com>
On Mon, Feb 20, 2012 at 09:00:14AM +0100, Gerd Hoffmann wrote:
> Hi,
>
> > I guess you will s/4/QXL_VRAM64_RANGE_INDEX/ when you send the
> > spice-protocol patch?
>
> Yes.
>
> >> - if (qxl->vram_size < 4096) {
> >> - qxl->vram_size = 4096;
> >> + if (qxl->vram_size < qxl->vram32_size) {
> >> + qxl->vram_size = qxl->vram32_size;
> >
> > Am I reading correctly that you want the 64bit bar to be at least the
> > size of the 32bit bar? why?
>
> The 64bit bar isn't additional memory. Both 32bit and 64bit bar are
> backed by the same memory, the 64bit bar is just a different way to
> access it. So it doesn't make sense at all to make the 64bit bar
> smaller than the 32bit bar. The other way around makes sense, to save
> address space below 4G.
Ok, thanks for the patient repetition of your clear commit message :)
ACK
>
> cheers,
> Gerd
>
prev parent reply other threads:[~2012-02-20 8:19 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-17 15:10 [Qemu-devel] [PATCH 0/4] qxl: memory config patches Gerd Hoffmann
2012-02-17 15:10 ` [Qemu-devel] [PATCH 1/4] qxl: drop vram bar minimum size Gerd Hoffmann
2012-02-17 19:27 ` Alon Levy
2012-02-17 19:28 ` Alon Levy
2012-02-17 15:10 ` [Qemu-devel] [PATCH 2/4] qxl: move ram size init to new function Gerd Hoffmann
2012-02-17 19:29 ` [Qemu-devel] [Spice-devel] " Alon Levy
2012-02-17 15:10 ` [Qemu-devel] [PATCH 3/4] qxl: add user-friendly bar size properties Gerd Hoffmann
2012-02-17 19:39 ` [Qemu-devel] [Spice-devel] " Alon Levy
2012-02-17 15:10 ` [Qemu-devel] [PATCH 4/4] [experimental] add optinal 64bit vram bar to qxl Gerd Hoffmann
2012-02-17 19:39 ` [Qemu-devel] [Spice-devel] " Alon Levy
2012-02-20 8:00 ` Gerd Hoffmann
2012-02-20 8:19 ` Alon Levy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120220081900.GV23926@garlic.redhat.com \
--to=alevy@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=spice-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).