From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:40003)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1RzZsl-0006BK-5x
	for qemu-devel@nongnu.org; Mon, 20 Feb 2012 15:30:48 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1RzZsk-000553-7Z
	for qemu-devel@nongnu.org; Mon, 20 Feb 2012 15:30:47 -0500
Received: from mx1.redhat.com ([209.132.183.28]:23452)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1RzZsk-00054w-0d
	for qemu-devel@nongnu.org; Mon, 20 Feb 2012 15:30:46 -0500
Date: Mon, 20 Feb 2012 22:30:46 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20120220203046.GD18751@redhat.com>
References: <1329498525-8454-1-git-send-email-anthony.perard@citrix.com>
	<1329498525-8454-4-git-send-email-anthony.perard@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1329498525-8454-4-git-send-email-anthony.perard@citrix.com>
Subject: Re: [Qemu-devel] [PATCH V7 03/11] pci_regs: Add
	PCI_EXP_TYPE_PCIE_BRIDGE
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Xen Devel <xen-devel@lists.xensource.com>, QEMU-devel <qemu-devel@nongnu.org>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>

On Fri, Feb 17, 2012 at 05:08:37PM +0000, Anthony PERARD wrote:
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> ---
>  hw/pci_regs.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/hw/pci_regs.h b/hw/pci_regs.h
> index 6b42515..56a404b 100644
> --- a/hw/pci_regs.h
> +++ b/hw/pci_regs.h
> @@ -392,6 +392,7 @@
>  #define  PCI_EXP_TYPE_UPSTREAM	0x5	/* Upstream Port */
>  #define  PCI_EXP_TYPE_DOWNSTREAM 0x6	/* Downstream Port */
>  #define  PCI_EXP_TYPE_PCI_BRIDGE 0x7	/* PCI/PCI-X Bridge */
> +#define  PCI_EXP_TYPE_PCIE_BRIDGE 0x8   /* PCI/PCI-X to PCIE Bridge */

I don't know why but linux source lacks this value, and we
try to stay in sync with that.
Please push there then we'll add here.
Meanwhile  put a define in your code.

>  #define  PCI_EXP_TYPE_RC_END	0x9	/* Root Complex Integrated Endpoint */
>  #define  PCI_EXP_TYPE_RC_EC     0xa     /* Root Complex Event Collector */
>  #define PCI_EXP_FLAGS_SLOT	0x0100	/* Slot implemented */
> -- 
> Anthony PERARD
>