From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:44375) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S00ui-0004sB-TN for qemu-devel@nongnu.org; Tue, 21 Feb 2012 20:22:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S00uh-0005bm-He for qemu-devel@nongnu.org; Tue, 21 Feb 2012 20:22:36 -0500 Received: from ozlabs.org ([203.10.76.45]:46684) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S00uh-0005bf-2p for qemu-devel@nongnu.org; Tue, 21 Feb 2012 20:22:35 -0500 Date: Wed, 22 Feb 2012 12:11:54 +1100 From: David Gibson Message-ID: <20120222011154.GN16796@truffala.fritz.box> References: <1329706897-30476-1-git-send-email-david@gibson.dropbear.id.au> <8A3EA298-2301-454F-81AE-301E1D898F50@suse.de> <4F435747.2020304@redhat.com> <4F435F2D.3010007@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F435F2D.3010007@redhat.com> Subject: Re: [Qemu-devel] [PATCH] Use DMADirection type for dma_bdrv_io List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: Paolo Bonzini , Alexander Graf , qemu-devel@nongnu.org On Tue, Feb 21, 2012 at 10:09:01AM +0100, Kevin Wolf wrote: > Am 21.02.2012 09:35, schrieb Paolo Bonzini: > > On 02/20/2012 11:50 AM, Alexander Graf wrote: > >>>> DMAAIOCB *dbs = qemu_aio_get(&dma_aio_pool, bs, cb, opaque); > >>>> > >>>> - trace_dma_bdrv_io(dbs, bs, sector_num, to_dev); > >>>> + trace_dma_bdrv_io(dbs, bs, sector_num, dir); > >> Was the trace wrong before or is it now? I don't see its definition changed anywhere. > > > > Not sure what you mean. :) > > trace-events: > > dma_bdrv_io(void *dbs, void *bs, int64_t sector_num, bool to_dev) > "dbs=%p bs=%p sector_num=%" PRId64 " to_dev=%d" Ah, damnit. Didn't find that file. I'll resubmit with trace-events updated too. > to_dev is declared bool here, and it should also be renamed to dir (the > unfortunate thing about DMADirection is that it swaps 0 and 1 compared > to bool to_dev... We need to check carefully that all occurrences have > been caught.) Yeah. And even more unfortunate that afaict there's no way to make gcc warn on enum<->bool conversions. Still there are only about 4 callers of dma_bdrv_io() - nearly everything uses the dma_bdrv_{read,write}() wrappers - so I'm confident I got them all. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson