From: 陳韋任 <chenwj@iis.sinica.edu.tw>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
陳韋任 <chenwj@iis.sinica.edu.tw>
Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] Fix dependency issue introduced by commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8
Date: Wed, 22 Feb 2012 10:08:07 +0800 [thread overview]
Message-ID: <20120222020807.GA10573@cs.nctu.edu.tw> (raw)
In-Reply-To: <CAJSP0QXhexX4wZUMjGb3mS6u7Rvfi4-ePmQeg=9g0-ZgTSmPsA@mail.gmail.com>
On Tue, Feb 21, 2012 at 12:27:26PM +0000, Stefan Hajnoczi wrote:
> On Tue, Feb 21, 2012 at 10:12 AM, 陳韋任 <chenwj@iis.sinica.edu.tw> wrote:
> > Commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8 adds basic version of bridge
> > helper, but introduces dependency issue at the same time. While building target
> > xxx-linux-user, qemu-bridge-helper.c needs config-host.h which is not generated
> > at the moment. Building recurse-all target first fixes the problem.
>
> The build system should not rely on ordering side-effects. Instead,
> please explicitly declare the dependency for the helper or see if the
> dependency can be eliminated if it is inappropriate.
O.K., since the dependency cannot be eliminated, I'll explicitly declare the
dependency for the helper.
Regards,
chenwj
--
Wei-Ren Chen (陳韋任)
Computer Systems Lab, Institute of Information Science,
Academia Sinica, Taiwan (R.O.C.)
Tel:886-2-2788-3799 #1667
Homepage: http://people.cs.nctu.edu.tw/~chenwj
prev parent reply other threads:[~2012-02-22 2:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-21 10:12 [Qemu-devel] [PATCH] Fix dependency issue introduced by commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8 陳韋任
2012-02-21 12:27 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
2012-02-22 2:08 ` 陳韋任 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120222020807.GA10573@cs.nctu.edu.tw \
--to=chenwj@iis.sinica.edu.tw \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=stefanha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).