[Qemu-devel] [PATCH] Fix dependency issue introduced by commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8

[Qemu-devel] [PATCH] Fix dependency issue introduced by commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8

[陳韋任]

  Commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8 adds basic version of bridge
helper, but introduces dependency issue at the same time. While building target
xxx-linux-user, qemu-bridge-helper.c needs config-host.h which is not generated
at the moment. Building recurse-all target first fixes the problem.  

Signed-off-by: Chen Wei-Ren <chenwj@iis.sinica.edu.tw>
---
 Makefile |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Makefile b/Makefile
index e66e885..618b306 100644
--- a/Makefile
+++ b/Makefile
@@ -79,7 +79,7 @@ defconfig:
 
 -include config-all-devices.mak
 
-build-all: $(DOCS) $(TOOLS) $(HELPERS-y) recurse-all
+build-all: $(DOCS) $(TOOLS) recurse-all $(HELPERS-y)
 
 config-host.h: config-host.h-timestamp
 config-host.h-timestamp: config-host.mak
-- 
1.7.3.4

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Fix dependency issue introduced by commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8

[Stefan Hajnoczi]

On Tue, Feb 21, 2012 at 10:12 AM, 陳韋任 <chenwj@iis.sinica.edu.tw> wrote:
>  Commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8 adds basic version of bridge
> helper, but introduces dependency issue at the same time. While building target
> xxx-linux-user, qemu-bridge-helper.c needs config-host.h which is not generated
> at the moment. Building recurse-all target first fixes the problem.

The build system should not rely on ordering side-effects.  Instead,
please explicitly declare the dependency for the helper or see if the
dependency can be eliminated if it is inappropriate.

Stefan

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Fix dependency issue introduced by commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8

[陳韋任]

On Tue, Feb 21, 2012 at 12:27:26PM +0000, Stefan Hajnoczi wrote:
> On Tue, Feb 21, 2012 at 10:12 AM, 陳韋任 <chenwj@iis.sinica.edu.tw> wrote:
> >  Commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8 adds basic version of bridge
> > helper, but introduces dependency issue at the same time. While building target
> > xxx-linux-user, qemu-bridge-helper.c needs config-host.h which is not generated
> > at the moment. Building recurse-all target first fixes the problem.
> 
> The build system should not rely on ordering side-effects.  Instead,
> please explicitly declare the dependency for the helper or see if the
> dependency can be eliminated if it is inappropriate.

  O.K., since the dependency cannot be eliminated, I'll explicitly declare the
dependency for the helper.

Regards,
chenwj

-- 
Wei-Ren Chen (陳韋任)
Computer Systems Lab, Institute of Information Science,
Academia Sinica, Taiwan (R.O.C.)
Tel:886-2-2788-3799 #1667
Homepage: http://people.cs.nctu.edu.tw/~chenwj