From: Luiz Capitulino <lcapitulino@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: kwolf@redhat.com, pbonzini@redhat.com, eblake@redhat.com,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v3 0/5]: QMP: add DEVICE_TRAY_MOVED event
Date: Wed, 22 Feb 2012 10:53:17 -0200 [thread overview]
Message-ID: <20120222105317.6ef8f865@doriath.home> (raw)
In-Reply-To: <m3ty2lq57k.fsf@blackfin.pond.sub.org>
On Mon, 20 Feb 2012 09:28:15 +0100
Markus Armbruster <armbru@redhat.com> wrote:
> Luiz Capitulino <lcapitulino@redhat.com> writes:
>
> > The event name changed, which caused the subject to change too, hope this
> > won't cause confusion.
> >
> > v3
> >
> > o Rename the event to DEVICE_TRAY_MOVED
> > o Rename the 'ejected' event data to 'tray-open'
> > o Only call bdrv_eject() if the tray state changed
> > o Drop ide_tray_state_post_load()
>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
Kevin, I'd like to get your ack before applying it to the qmp branch.
next prev parent reply other threads:[~2012-02-22 13:05 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-17 19:21 [Qemu-devel] [PATCH v3 0/5]: QMP: add DEVICE_TRAY_MOVED event Luiz Capitulino
2012-02-17 19:21 ` [Qemu-devel] [PATCH 1/5] block: Rename bdrv_mon_event() & BlockMonEventAction Luiz Capitulino
2012-02-17 19:21 ` [Qemu-devel] [PATCH 2/5] block: bdrv_eject(): Make eject_flag a real bool Luiz Capitulino
2012-02-17 19:21 ` [Qemu-devel] [PATCH 3/5] block: Don't call bdrv_eject() if the tray state didn't change Luiz Capitulino
2012-02-20 8:16 ` Markus Armbruster
2012-02-17 19:21 ` [Qemu-devel] [PATCH 4/5] ide: drop ide_tray_state_post_load() Luiz Capitulino
2012-02-20 8:20 ` Markus Armbruster
2012-02-17 19:21 ` [Qemu-devel] [PATCH 5/5] qmp: add DEVICE_TRAY_MOVED event Luiz Capitulino
2012-02-20 8:27 ` Markus Armbruster
2012-02-22 13:23 ` Kevin Wolf
2012-02-23 7:50 ` Markus Armbruster
2012-02-23 12:17 ` Luiz Capitulino
2012-02-23 14:08 ` Markus Armbruster
2012-02-24 16:01 ` Anthony Liguori
2012-02-24 16:39 ` Luiz Capitulino
2012-02-24 16:44 ` Anthony Liguori
2012-02-24 16:56 ` Luiz Capitulino
2012-02-24 17:19 ` [Qemu-devel] New QMP event interface (was Re: [PATCH 5/5] qmp: add DEVICE_TRAY_MOVED event) Anthony Liguori
2012-02-20 8:28 ` [Qemu-devel] [PATCH v3 0/5]: QMP: add DEVICE_TRAY_MOVED event Markus Armbruster
2012-02-22 12:53 ` Luiz Capitulino [this message]
2012-02-22 13:23 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120222105317.6ef8f865@doriath.home \
--to=lcapitulino@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).