From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:60534)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1S0Bsu-00009o-JT
	for qemu-devel@nongnu.org; Wed, 22 Feb 2012 08:05:38 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1S0Bso-0001FC-Mv
	for qemu-devel@nongnu.org; Wed, 22 Feb 2012 08:05:28 -0500
Received: from mx1.redhat.com ([209.132.183.28]:56682)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1S0Bso-0001Ex-8u
	for qemu-devel@nongnu.org; Wed, 22 Feb 2012 08:05:22 -0500
Received: from int-mx02.intmail.prod.int.phx2.redhat.com
	(int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1MD5KYX006139
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 22 Feb 2012 08:05:21 -0500
Date: Wed, 22 Feb 2012 10:53:17 -0200
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20120222105317.6ef8f865@doriath.home>
In-Reply-To: <m3ty2lq57k.fsf@blackfin.pond.sub.org>
References: <1329506504-29152-1-git-send-email-lcapitulino@redhat.com>
	<m3ty2lq57k.fsf@blackfin.pond.sub.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v3 0/5]: QMP: add DEVICE_TRAY_MOVED event
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: kwolf@redhat.com, pbonzini@redhat.com, eblake@redhat.com, qemu-devel@nongnu.org

On Mon, 20 Feb 2012 09:28:15 +0100
Markus Armbruster <armbru@redhat.com> wrote:

> Luiz Capitulino <lcapitulino@redhat.com> writes:
> 
> > The event name changed, which caused the subject to change too, hope this
> > won't cause confusion.
> >
> > v3
> >
> > o Rename the event to DEVICE_TRAY_MOVED
> > o Rename the 'ejected' event data to 'tray-open'
> > o Only call bdrv_eject() if the tray state changed
> > o Drop ide_tray_state_post_load()
> 
> Reviewed-by: Markus Armbruster <armbru@redhat.com>

Kevin, I'd like to get your ack before applying it to the qmp branch.