From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:53564) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0BJO-0006dd-VT for qemu-devel@nongnu.org; Wed, 22 Feb 2012 07:28:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S0BJM-0002o7-3U for qemu-devel@nongnu.org; Wed, 22 Feb 2012 07:28:46 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37659) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0BJL-0002o1-NC for qemu-devel@nongnu.org; Wed, 22 Feb 2012 07:28:44 -0500 Date: Wed, 22 Feb 2012 13:28:36 +0100 From: Alon Levy Message-ID: <20120222122835.GC607@garlic.redhat.com> References: <1329860377-6284-1-git-send-email-alevy@redhat.com> <1329860377-6284-7-git-send-email-alevy@redhat.com> <4F44CF1A.6080703@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F44CF1A.6080703@redhat.com> Subject: Re: [Qemu-devel] [RFC v4 6/9] qxl: remove flipped List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: spice-devel@freedesktop.org, yhalperi@redhat.com, qemu-devel@nongnu.org, elmarco@redhat.com On Wed, Feb 22, 2012 at 12:18:50PM +0100, Gerd Hoffmann wrote: > Hi, > > It's not obvious to me how the non-flipped case (qxl_stride > 0) is > handled now. Have you tested this with both windows+linux guests? It isn't handled. The simplest way is just to if on the stride and do a single memcpy instead of individual line memcpy. This of course means we are doing a redundant copy, since using our own DisplayAllocator or just the existing deallocate + our own allocate of ds->surface->data removes one copy. Since the main use case is screendump, I don't think it's a big deal. How does that sound? > > cheers, > Gerd > >