From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:46394) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0DCS-0001eZ-8v for qemu-devel@nongnu.org; Wed, 22 Feb 2012 09:29:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S0DCR-0001UU-7g for qemu-devel@nongnu.org; Wed, 22 Feb 2012 09:29:44 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51431) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0DCQ-0001Tz-Vs for qemu-devel@nongnu.org; Wed, 22 Feb 2012 09:29:43 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1METgVi026906 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 22 Feb 2012 09:29:42 -0500 Date: Wed, 22 Feb 2012 15:29:33 +0100 From: Alon Levy Message-ID: <20120222142933.GD8461@garlic> References: <1329686886-6853-6-git-send-email-alevy@redhat.com> <4F422F5C.9060202@redhat.com> <4F42BB27.6070504@redhat.com> <20120221081948.GC6476@garlic> <4F43C331.7090000@redhat.com> <20120221174016.GO6476@garlic> <20120222111717.0c56390f@doriath.home> <20120222132250.GG607@garlic.redhat.com> <20120222114927.4c303fd0@doriath.home> <4F44FA13.7080607@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F44FA13.7080607@redhat.com> Subject: Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: Eric Blake , qemu-devel@nongnu.org, elmarco@redhat.com, Luiz Capitulino On Wed, Feb 22, 2012 at 03:22:11PM +0100, Gerd Hoffmann wrote: > Hi, > > > Honestly, for this particular case, I'm not 100% sure that having an id is > > _required_, as I don't expect a client to submit multiple screendump calls > > in parallel and we don't "officially" support multiple QMP clients either. > > Also, having the screendump filename in the event will serve as a form of > > identifier too. > > That is exactly my thinking, echo the filename written in the event. > > > Btw, are you planning to add the event to the already existing screendump > > command? Adding a new command that doesn't use the monitor async API and > > is truly asynchronous wouldn't better? > > Good question. I'd tend to just let the existing command send trigger > an event. But libvirt needs some way to figure whenever it should wait > for an event ... Right, that's the second reason I think a new command is needed. Additionally a new command can be implemented only by qxl and not by anything else (although I guess that would be a NACK?) > > cheers, > Gerd