From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:50212) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0HqS-0004nV-Ml for qemu-devel@nongnu.org; Wed, 22 Feb 2012 14:27:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S0HqR-0000GX-Mo for qemu-devel@nongnu.org; Wed, 22 Feb 2012 14:27:20 -0500 Received: from mx1.redhat.com ([209.132.183.28]:12874) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0HqR-0000GI-9P for qemu-devel@nongnu.org; Wed, 22 Feb 2012 14:27:19 -0500 Date: Wed, 22 Feb 2012 17:27:18 -0200 From: Luiz Capitulino Message-ID: <20120222172718.12dc865b@doriath.home> In-Reply-To: <20120222163515.GG8461@garlic> References: <4F42BB27.6070504@redhat.com> <20120221081948.GC6476@garlic> <4F43C331.7090000@redhat.com> <20120221174016.GO6476@garlic> <20120222111717.0c56390f@doriath.home> <20120222132250.GG607@garlic.redhat.com> <20120222114927.4c303fd0@doriath.home> <4F44FA13.7080607@redhat.com> <20120222142933.GD8461@garlic> <20120222135545.41511e25@doriath.home> <20120222163515.GG8461@garlic> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC 5/7] qxl-render: call ppm_save on callback List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alon Levy Cc: aliguori@us.ibm.com, Eric Blake , Gerd Hoffmann , elmarco@redhat.com, qemu-devel@nongnu.org On Wed, 22 Feb 2012 17:35:15 +0100 Alon Levy wrote: > On Wed, Feb 22, 2012 at 01:55:45PM -0200, Luiz Capitulino wrote: > > On Wed, 22 Feb 2012 15:29:33 +0100 > > Alon Levy wrote: > > > > > On Wed, Feb 22, 2012 at 03:22:11PM +0100, Gerd Hoffmann wrote: > > > > Hi, > > > > > > > > > Honestly, for this particular case, I'm not 100% sure that having an id is > > > > > _required_, as I don't expect a client to submit multiple screendump calls > > > > > in parallel and we don't "officially" support multiple QMP clients either. > > > > > Also, having the screendump filename in the event will serve as a form of > > > > > identifier too. > > > > > > > > That is exactly my thinking, echo the filename written in the event. > > > > > > > > > Btw, are you planning to add the event to the already existing screendump > > > > > command? Adding a new command that doesn't use the monitor async API and > > > > > is truly asynchronous wouldn't better? > > > > > > > > Good question. I'd tend to just let the existing command send trigger > > > > an event. But libvirt needs some way to figure whenever it should wait > > > > for an event ... > > > > > > Right, that's the second reason I think a new command is needed. > > > Additionally a new command can be implemented only by qxl and not by > > > anything else (although I guess that would be a NACK?) > > > > Is there anything specific to qlx in the command? If there's, then you > > should also consider making this a QOM device property. The downside is > > that QOM commands are not going to be stable for 1.1. > > qxl is the only one that needs the async stuff since it needs to ask > spice-server to do the rendering, which is done in another thread > outside of qemu control. The rest of the screendump implementations > afaict don't need any such complexity. In theory, any file I/O should be asynchronous. > The command itself would not be specific to qxl. > > I thought I just need a QAPI command, and docs/ say QMP doesn't use that > yet, so what's the connection to QMP? Not sure I can follow you here, "that" what?