From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:53702) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0I7F-00084t-DW for qemu-devel@nongnu.org; Wed, 22 Feb 2012 14:44:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S0I7D-0003RT-Py for qemu-devel@nongnu.org; Wed, 22 Feb 2012 14:44:41 -0500 Received: from mx1.redhat.com ([209.132.183.28]:3687) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0I7D-0003RO-Fs for qemu-devel@nongnu.org; Wed, 22 Feb 2012 14:44:39 -0500 Date: Wed, 22 Feb 2012 17:44:37 -0200 From: Luiz Capitulino Message-ID: <20120222174437.3626fafe@doriath.home> In-Reply-To: <20120222165445.GB2824@illuin> References: <1328733040-16697-1-git-send-email-lcapitulino@redhat.com> <1328733040-16697-7-git-send-email-lcapitulino@redhat.com> <4F3E868D.8020107@us.ibm.com> <20120217151622.682d307b@doriath.home> <20120217215133.GE20920@illuin> <20120222104813.650f7779@doriath.home> <20120222150522.GA2824@illuin> <20120222140935.7a01acda@doriath.home> <20120222165445.GB2824@illuin> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 6/6] qmp: add balloon-get-memory-stats & event List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Roth Cc: armbru@redhat.com, Anthony Liguori , eblake@redhat.com, qemu-devel@nongnu.org, agl@us.ibm.com On Wed, 22 Feb 2012 10:54:45 -0600 Michael Roth wrote: > But I'm not suggesting we make query-balloon asynchronous. > > I'm suggesting be re-enable it as a synchronous interface by having it > immediately return the latest-available results from a timer-driven > query mechanism that tucks away the query results, such as the one Anthony > suggested. I'm not sure I like the semantics, as query-balloon would have some fields that actually depends on a timer based polling being enabled somewhere else, while others fields ('actual') would always be there. > > But that's a dead discussion I guess, as I already agreed on implementing > > this as a device property. > > Along with timer-based refresh of the properties? If so I don't understand why we > can't just have query-balloon simply return those properties when it's called? I > thought that's what Anthony was driving at with the timer-based > approach. What I had understood is to make each stats a dynamic device property, then mngt apps would use qom-set/get on them. Anthony, can you detail your suggestion please?