From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:46159)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1S0Xbw-0005MD-9T
	for qemu-devel@nongnu.org; Thu, 23 Feb 2012 07:17:32 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1S0Xbq-00044E-FD
	for qemu-devel@nongnu.org; Thu, 23 Feb 2012 07:17:24 -0500
Received: from mx1.redhat.com ([209.132.183.28]:60774)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1S0Xbq-00044A-8b
	for qemu-devel@nongnu.org; Thu, 23 Feb 2012 07:17:18 -0500
Received: from int-mx12.intmail.prod.int.phx2.redhat.com
	(int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1NCHGRu009850
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Thu, 23 Feb 2012 07:17:16 -0500
Date: Thu, 23 Feb 2012 10:17:17 -0200
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20120223101717.5e5886b9@doriath.home>
In-Reply-To: <m3ipiy9efj.fsf@blackfin.pond.sub.org>
References: <1329506504-29152-1-git-send-email-lcapitulino@redhat.com>
	<1329506504-29152-6-git-send-email-lcapitulino@redhat.com>
	<4F44EC3B.9090902@redhat.com>
	<m3ipiy9efj.fsf@blackfin.pond.sub.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 5/5] qmp: add DEVICE_TRAY_MOVED event
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, pbonzini@redhat.com, eblake@redhat.com, qemu-devel@nongnu.org

On Thu, 23 Feb 2012 08:50:08 +0100
Markus Armbruster <armbru@redhat.com> wrote:

> Kevin Wolf <kwolf@redhat.com> writes:
> 
> > Am 17.02.2012 20:21, schrieb Luiz Capitulino:
> >> It's emitted whenever the tray is moved by the guest or by HMP/QMP
> >> commands.
> >> 
> >> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
> >> ---
> >>  QMP/qmp-events.txt |   18 ++++++++++++++++++
> >>  block.c            |   24 ++++++++++++++++++++++++
> >>  monitor.c          |    3 +++
> >>  monitor.h          |    1 +
> >>  4 files changed, 46 insertions(+), 0 deletions(-)
> >> 
> >> diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt
> >> index 06cb404..9286af5 100644
> >> --- a/QMP/qmp-events.txt
> >> +++ b/QMP/qmp-events.txt
> >> @@ -26,6 +26,24 @@ Example:
> >>  Note: If action is "stop", a STOP event will eventually follow the
> >>  BLOCK_IO_ERROR event.
> >>  
> >> +DEVICE_TRAY_MOVED
> >> +-----------------
> >> +
> >> +It's emitted whenever the tray of a removable device is moved by the guest
> >> +or by HMP/QMP commands.
> >> +
> >> +Data:
> >> +
> >> +- "device": device name (json-string)
> >
> > For me, a device name is something related to qdev. 'device' is a
> > misnomer consistently used in all QMP commands so far and we can't fix
> > it any more, but at least the documentation should clarify what is meant
> > (that's for a follow-up patch).
> 
> We can fix it if we really want to: rename, then add the old name as
> alias for backward compatibility.  Pick your favourite flavor of cruft.

I like it, new events won't have the cruft.