From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:56451) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0nfR-0005Fl-Rb for qemu-devel@nongnu.org; Fri, 24 Feb 2012 00:26:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S0nfN-0002v5-Q4 for qemu-devel@nongnu.org; Fri, 24 Feb 2012 00:26:04 -0500 Received: from ozlabs.org ([203.10.76.45]:33823) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0nfN-0002ut-Aw for qemu-devel@nongnu.org; Fri, 24 Feb 2012 00:26:01 -0500 Date: Fri, 24 Feb 2012 15:57:36 +1100 From: David Gibson Message-ID: <20120224045736.GR16796@truffala.fritz.box> References: <1330054063-16860-1-git-send-email-david@gibson.dropbear.id.au> <1330054063-16860-9-git-send-email-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1330054063-16860-9-git-send-email-david@gibson.dropbear.id.au> Subject: Re: [Qemu-devel] [PATCH 8/8] Make dma_addr_t 64 bit always List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anthony@codemonkey.ws Cc: qemu-devel@nongnu.org On Fri, Feb 24, 2012 at 02:27:43PM +1100, David Gibson wrote: Oops, ignore this one folks. As is probably obvious, this was a testing patch not meant to go into the main series. > --- > dma.h | 9 ++++++--- > 1 files changed, 6 insertions(+), 3 deletions(-) > > diff --git a/dma.h b/dma.h > index b8cfd1d..ee540f4 100644 > --- a/dma.h > +++ b/dma.h > @@ -18,10 +18,13 @@ > typedef struct ScatterGatherEntry ScatterGatherEntry; > > #if defined(TARGET_PHYS_ADDR_BITS) > -typedef target_phys_addr_t dma_addr_t; > +/* Bus addresses can be different size from CPU physical addresses, > + * and indeed they can be different on different busses. So make > + * these always 64-bit which should handle every usual case */ > +typedef uint64_t dma_addr_t; > > -#define DMA_ADDR_BITS TARGET_PHYS_ADDR_BITS > -#define DMA_ADDR_FMT TARGET_FMT_plx > +#define DMA_ADDR_BITS 64 > +#define DMA_ADDR_FMT "%" PRIx64 > > typedef enum { > DMA_DIRECTION_TO_DEVICE = 0, -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson