From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46467) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0wwm-00011l-Js for qemu-devel@nongnu.org; Fri, 24 Feb 2012 10:20:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S0wwl-0002RX-5M for qemu-devel@nongnu.org; Fri, 24 Feb 2012 10:20:36 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54489) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0wwk-0002RO-UF for qemu-devel@nongnu.org; Fri, 24 Feb 2012 10:20:35 -0500 Date: Fri, 24 Feb 2012 13:20:34 -0200 From: Luiz Capitulino Message-ID: <20120224132034.5573c4fc@doriath.home> In-Reply-To: <4F47A5AF.5070707@us.ibm.com> References: <1330092792-22455-1-git-send-email-lcapitulino@redhat.com> <4F47A5AF.5070707@us.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/5]: Improve machine type functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Peter Maydell , qemu-devel@nongnu.org, Andreas =?ISO-8859-1?B?RuRyYmVy?= On Fri, 24 Feb 2012 08:58:55 -0600 Anthony Liguori wrote: > On 02/24/2012 08:13 AM, Luiz Capitulino wrote: > > I was reading some related code yesterday and couldn't resist improving this. > > Not sure if this is aligned with any possible QOM work in this area, but I'm > > posting this anyway... > > I'm not sure how easy this is, but the way to do this with QOM would be: This seems like a cool thing to work on. The two major problems (for me at least) is testing and the possible huge amount of manual work, or do you think that most of the work can be automated? The problem with testing is that, we have a whole lot of machines I have no idea what's the best way of testing the conversion work. [...] > That's not to say this series isn't a good cleanup. I haven't actually reviewed > it yet. I just wanted to illustrate the next QOM steps. Ok. I honestly think that this series is a small first step. Even the QTAILQ conversion is worth it IMHO, because it clearly shows what the function is doing in a single line.