From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:46838) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0wyK-00022y-3J for qemu-devel@nongnu.org; Fri, 24 Feb 2012 10:22:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S0wyF-0002d4-Ko for qemu-devel@nongnu.org; Fri, 24 Feb 2012 10:22:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:61493) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0wyF-0002cu-DJ for qemu-devel@nongnu.org; Fri, 24 Feb 2012 10:22:07 -0500 Date: Fri, 24 Feb 2012 13:22:08 -0200 From: Luiz Capitulino Message-ID: <20120224132208.26e53926@doriath.home> In-Reply-To: <4F47A859.5010807@suse.de> References: <1330092792-22455-1-git-send-email-lcapitulino@redhat.com> <1330092792-22455-6-git-send-email-lcapitulino@redhat.com> <4F47A859.5010807@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 5/5] boards: move all machine type functions to boards.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?ISO-8859-1?B?RuRyYmVy?= Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org On Fri, 24 Feb 2012 16:10:17 +0100 Andreas F=E4rber wrote: > Am 24.02.2012 15:13, schrieb Luiz Capitulino: > > The license text is the same as used in vl.c. Also note that it's > > necessary to make machine_parse() public. > >=20 > > Signed-off-by: Luiz Capitulino > > --- > > Makefile.target | 3 +- > > hw/boards.c | 86 +++++++++++++++++++++++++++++++++++++++++++++++= ++++++++ > > hw/boards.h | 1 + > > vl.c | 65 ----------------------------------------- > > 4 files changed, 89 insertions(+), 66 deletions(-) > > create mode 100644 hw/boards.c >=20 > In anticipation of a "board" class derived from "container" I would > rather have the file name match the class name, i.e. board.c. > Unfortunately boards.h is used in quite a lot of places already, but > when we QOM'ify it we might want to move it to include/qemu so all users > would need to be touched anyway. I don't min doing the rename work, but Anthony is talking about having a Ma= chine type. So, maybe it's a better idea to do rename along with the QOM conversi= on, as that's when we'll be sure about the class name. > > diff --git a/Makefile.target b/Makefile.target > > index d5eb70d..dc76eba 100644 > > --- a/Makefile.target > > +++ b/Makefile.target > > @@ -195,7 +195,8 @@ endif #CONFIG_BSD_USER > > # System emulator target > > ifdef CONFIG_SOFTMMU > > =20 > > -obj-y =3D arch_init.o cpus.o monitor.o machine.o gdbstub.o balloon.o i= oport.o > > +obj-y =3D arch_init.o cpus.o monitor.o machine.o gdbstub.o balloon.o i= oport.o \ > > + boards.o >=20 > Please use obj-y +=3D ... instead of the line break. Ok. >=20 > Otherwise looks okay. >=20 > Andreas >=20