From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59833) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0yAw-0007HG-DH for qemu-devel@nongnu.org; Fri, 24 Feb 2012 11:39:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S0yAq-0007p4-99 for qemu-devel@nongnu.org; Fri, 24 Feb 2012 11:39:18 -0500 Received: from mx1.redhat.com ([209.132.183.28]:19248) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S0yAq-0007oz-18 for qemu-devel@nongnu.org; Fri, 24 Feb 2012 11:39:12 -0500 Date: Fri, 24 Feb 2012 14:39:11 -0200 From: Luiz Capitulino Message-ID: <20120224143911.018b2073@doriath.home> In-Reply-To: <4F47B43C.8050008@codemonkey.ws> References: <1329506504-29152-1-git-send-email-lcapitulino@redhat.com> <1329506504-29152-6-git-send-email-lcapitulino@redhat.com> <4F44EC3B.9090902@redhat.com> <20120223101717.5e5886b9@doriath.home> <4F47B43C.8050008@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 5/5] qmp: add DEVICE_TRAY_MOVED event List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Kevin Wolf , pbonzini@redhat.com, eblake@redhat.com, Markus Armbruster , qemu-devel@nongnu.org On Fri, 24 Feb 2012 10:01:00 -0600 Anthony Liguori wrote: > On 02/23/2012 08:08 AM, Markus Armbruster wrote: > > Luiz Capitulino writes: > > > >> On Thu, 23 Feb 2012 08:50:08 +0100 > >> Markus Armbruster wrote: > >> > >>> Kevin Wolf writes: > >>> > >>>> Am 17.02.2012 20:21, schrieb Luiz Capitulino: > >>>>> It's emitted whenever the tray is moved by the guest or by HMP/QMP > >>>>> commands. > >>>>> > >>>>> Signed-off-by: Luiz Capitulino > >>>>> --- > >>>>> QMP/qmp-events.txt | 18 ++++++++++++++++++ > >>>>> block.c | 24 ++++++++++++++++++++++++ > >>>>> monitor.c | 3 +++ > >>>>> monitor.h | 1 + > >>>>> 4 files changed, 46 insertions(+), 0 deletions(-) > >>>>> > >>>>> diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt > >>>>> index 06cb404..9286af5 100644 > >>>>> --- a/QMP/qmp-events.txt > >>>>> +++ b/QMP/qmp-events.txt > >>>>> @@ -26,6 +26,24 @@ Example: > >>>>> Note: If action is "stop", a STOP event will eventually follow the > >>>>> BLOCK_IO_ERROR event. > >>>>> > >>>>> +DEVICE_TRAY_MOVED > >>>>> +----------------- > >>>>> + > >>>>> +It's emitted whenever the tray of a removable device is moved by the guest > >>>>> +or by HMP/QMP commands. > >>>>> + > >>>>> +Data: > >>>>> + > >>>>> +- "device": device name (json-string) > >>>> > >>>> For me, a device name is something related to qdev. 'device' is a > >>>> misnomer consistently used in all QMP commands so far and we can't fix > >>>> it any more, but at least the documentation should clarify what is meant > >>>> (that's for a follow-up patch). > >>> > >>> We can fix it if we really want to: rename, then add the old name as > >>> alias for backward compatibility. Pick your favourite flavor of cruft. > >> > >> I like it, new events won't have the cruft. > > > > If we reserve "device" for device models, we need sensible names for > > device backends. One each for block, net and char. There's some > > precedence for "blockdev", "netdev", "chardev", but they contain "dev", > > so there's still some overloading of the name "device". Better ideas? > > For 1.2 (when QOM is considered stable), this should become pathname. Given a > path, a client can determine what the type of the object is (by reading the type > property). > > In fact, I'd like to see all events have a pathname of origin. This would > probably become part of the QMP protocol itself. > > This gives us a mechanism to subscribe to events from specific objects. This is 1.2 material, right? I'm asking because the conversion of events to the qapi is not too far away, but I think that using QOM will somewhat deprecate the code you have in the glib branch (besides having to wait for 1.2)?