From: Alon Levy <alevy@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
Stefan Weil <sw@weilnetz.de>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] libcacard: Spelling and grammar fixes in documentation
Date: Mon, 27 Feb 2012 23:24:14 +0200 [thread overview]
Message-ID: <20120227212414.GQ7395@garlic.redhat.com> (raw)
In-Reply-To: <CAFEAcA_82UCPWVukhAWcxGjeRQfkb+_E7OOdx8fh9y-6Ya_OMg@mail.gmail.com>
On Sun, Feb 26, 2012 at 06:18:04PM +0000, Peter Maydell wrote:
> On 26 February 2012 13:30, Stefan Weil <sw@weilnetz.de> wrote:
> > @@ -217,10 +217,10 @@ the card using the following functions:
> > VCardStatus vcard_add_applet(VCard *card, VCardApplet *applet);
> >
> > Add an applet onto the list of applets attached to the card. Once an applet
> > - has been added, it can be selected by it's aid, and then commands will be
> > + has been added, it can be selected by its aid, and then commands will be
>
> While you're changing this line, it looks like 'aid' here should be 'AID'
> (it is capitalised elsewhere in the doc except where referring to a function
> parameter name).
>
> > routed to it VCardProcessAPDU function. This function adopts the applet the
> > passed int applet.
>
> The sentence "This function..." clearly needs correcting as it doesn't
> make much sense as it stands, but I'm not sure what it should be changed to.
Asked Robert Relyea (rrelyea@redhat.com - I guess he should be in
MAINTAINERS, although he is not..) and the answer was:
This function adopts the applet that is passed into it.
>
> > Note: 2 applets with the same AID should not be added to
> > - the same card. It's permissible to add more than one applet. Multiple applets
> > + the same card. It is permissible to add more than one applet. Multiple applets
> > may have the same VCardPRocessAPDU entry point.
>
> -- PMM
>
prev parent reply other threads:[~2012-02-27 21:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-26 13:30 [Qemu-devel] [PATCH] libcacard: Spelling and grammar fixes in documentation Stefan Weil
2012-02-26 13:38 ` Alon Levy
2012-02-26 18:18 ` Peter Maydell
2012-02-26 18:52 ` Stefan Weil
2012-02-27 21:24 ` Alon Levy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120227212414.GQ7395@garlic.redhat.com \
--to=alevy@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).