From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:42865)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1S283p-0005Js-6x
	for qemu-devel@nongnu.org; Mon, 27 Feb 2012 16:24:46 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1S283b-0006Hx-If
	for qemu-devel@nongnu.org; Mon, 27 Feb 2012 16:24:44 -0500
Date: Mon, 27 Feb 2012 23:24:14 +0200
From: Alon Levy <alevy@redhat.com>
Message-ID: <20120227212414.GQ7395@garlic.redhat.com>
References: <1330263021-1339-1-git-send-email-sw@weilnetz.de>
	<CAFEAcA_82UCPWVukhAWcxGjeRQfkb+_E7OOdx8fh9y-6Ya_OMg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <CAFEAcA_82UCPWVukhAWcxGjeRQfkb+_E7OOdx8fh9y-6Ya_OMg@mail.gmail.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] libcacard: Spelling and grammar fixes in
 documentation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>, Stefan Weil <sw@weilnetz.de>, qemu-devel@nongnu.org

On Sun, Feb 26, 2012 at 06:18:04PM +0000, Peter Maydell wrote:
> On 26 February 2012 13:30, Stefan Weil <sw@weilnetz.de> wrote:
> > @@ -217,10 +217,10 @@ the card using the following functions:
> > =A0 =A0 =A0 =A0 =A0VCardStatus vcard_add_applet(VCard *card, VCardApp=
let *applet);
> >
> > =A0 Add an applet onto the list of applets attached to the card. Once=
 an applet
> > - =A0has been added, it can be selected by it's aid, and then command=
s will be
> > + =A0has been added, it can be selected by its aid, and then commands=
 will be
>=20
> While you're changing this line, it looks like 'aid' here should be 'AI=
D'
> (it is capitalised elsewhere in the doc except where referring to a fun=
ction
> parameter name).
>=20
> > =A0 routed to it VCardProcessAPDU function. This function adopts the =
applet the
> > =A0 passed int applet.
>=20
> The sentence "This function..." clearly needs correcting as it doesn't
> make much sense as it stands, but I'm not sure what it should be change=
d to.

Asked Robert Relyea (rrelyea@redhat.com - I guess he should be in
MAINTAINERS, although he is not..) and the answer was:
 This function adopts the applet that is passed into it.

>=20
> > Note: 2 applets with the same AID should not be added to
> > - =A0the same card. It's permissible to add more than one applet. Mul=
tiple applets
> > + =A0the same card. It is permissible to add more than one applet. Mu=
ltiple applets
> > =A0 may have the same VCardPRocessAPDU entry point.
>=20
> -- PMM
>=20