From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38693) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2DDE-0002u0-85 for qemu-devel@nongnu.org; Mon, 27 Feb 2012 21:54:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S2DCv-0003da-Gm for qemu-devel@nongnu.org; Mon, 27 Feb 2012 21:54:47 -0500 Received: from ozlabs.org ([203.10.76.45]:45139) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2DCv-0003b8-4B for qemu-devel@nongnu.org; Mon, 27 Feb 2012 21:54:29 -0500 Date: Tue, 28 Feb 2012 12:07:13 +1100 From: David Gibson Message-ID: <20120228010713.GK3433@truffala.fritz.box> References: <1330043012-30556-1-git-send-email-david@gibson.dropbear.id.au> <1330043012-30556-3-git-send-email-david@gibson.dropbear.id.au> <4F4B8BEF.7010500@siemens.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F4B8BEF.7010500@siemens.com> Subject: Re: [Qemu-devel] [PATCH 2/6] slirp: Fix assertion failure on rejected DHCP requests List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: "qemu-devel@nongnu.org" , "anthony@codemonkey.ws" On Mon, Feb 27, 2012 at 02:58:07PM +0100, Jan Kiszka wrote: > On 2012-02-24 01:23, David Gibson wrote: > > The guest network stack might DHCPREQUEST an address that the slirp built > > in dhcp server can't let it have - for example if the guest has an old > > leases file from another network configuration. In this case the dhcp > > server should and does reject the request and prepares to send a DHCPNAK > > to the client. > > > > However, in this case the daddr variable in bootp_reply() is set to > > 0.0.0.0. Shortly afterwards, it unconditionally attempts to pre-insert the > > new client address into the ARP table. This causes an assertion failure in > > arp_address_add() because of the 0.0.0.0 address. > > > > According to RFC2131, DHCPNAK messages for clients on the same subnet > > must be sent to the broadcast address (S3.2, subpoint 2). > > > > Cc: Jan Kiszka > > > > Signed-off-by: David Gibson > > Thanks, applied to the slirp queue. Thanks. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson