From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:38224)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1S2ITU-0002ps-Sq
	for qemu-devel@nongnu.org; Tue, 28 Feb 2012 03:32:02 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1S2ITF-0000bE-79
	for qemu-devel@nongnu.org; Tue, 28 Feb 2012 03:31:56 -0500
Received: from mx1.redhat.com ([209.132.183.28]:35129)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1S2ITE-0000b2-VP
	for qemu-devel@nongnu.org; Tue, 28 Feb 2012 03:31:41 -0500
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1S8VdhP029845
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 28 Feb 2012 03:31:39 -0500
Date: Tue, 28 Feb 2012 10:31:33 +0200
From: Alon Levy <alevy@redhat.com>
Message-ID: <20120228083133.GD10291@garlic.redhat.com>
References: <1330337410-21905-1-git-send-email-kraxel@redhat.com>
	<20120227191337.GM7395@garlic.redhat.com>
	<4F4C9072.8040903@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4F4C9072.8040903@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] qxl: properly handle upright and
 non-shared surfaces
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: qemu-devel@nongnu.org

On Tue, Feb 28, 2012 at 09:29:38AM +0100, Gerd Hoffmann wrote:
> >> -    dprint(qxl, 1, "%s: stride %d, [%d, %d, %d, %d]\n", __func__,
> >> +    dprint(qxl, 2, "%s: stride %d, [%d, %d, %d, %d]\n", __func__,
> > 
> > You know 2 is used right now for high frequency stuff, like
> > interface_get_command? I think this should be lower. Anyway, not a big
> > deal.
> 
> /me used '1' for important but infrequent stuff, basically all init ops,
> mode switching etc.  This can happen quite alot in case you are running
> with SDL.  Maybe we need not just 1+2 but 1+2+3 levels, with 3 for the
> really frequent stuff which will flood the logfiles.
> 
> Or even better just turn them all into tracepoints ...
> 

Yeah, I started working on this but didn't finish. I'll try to do it.

> cheers,
>   Gerd
> 
>