From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [Bug 942659] Re: ARM: CORTEX M, PRIMASK does not disable interrupts
Date: Tue, 28 Feb 2012 15:15:03 -0000 [thread overview]
Message-ID: <20120228151503.18562.8051.malone@soybean.canonical.com> (raw)
In-Reply-To: 20120228144943.7111.8880.malonedeb@gac.canonical.com
> This change changes the behaviour for non-M-profile cores
...or maybe not: I was confused by the resemblance to that other patch.
I still think one-line fixes are unlikely to be the right approach here,
though.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/942659
Title:
ARM: CORTEX M, PRIMASK does not disable interrupts
Status in QEMU:
New
Bug description:
qemu version 0.15.1
but the same code is in qemu 1.0
"CPSID I" does not disable interrupts for CORTEX M3
if (interrupt_request & CPU_INTERRUPT_HARD
&& ((IS_M(env) && env->regs[15] < 0xfffffff0)
|| !(env->uncached_cpsr & CPSR_I))) {
env->exception_index = EXCP_IRQ;
do_interrupt(env);
next_tb = 0;
}
do_interrupt() will be executed even if (env->uncached_cpsr & CPSR_I) == 1 , disable interrupt bit set.
then changed to:
if (interrupt_request & CPU_INTERRUPT_HARD
&& !(env->uncached_cpsr & CPSR_I)
&& (IS_M(env) ? env->regs[15] < 0xfffffff0: 1) ) {
env->exception_index = EXCP_IRQ;
do_interrupt(env);
next_tb = 0;
}
works
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/942659/+subscriptions
next prev parent reply other threads:[~2012-02-28 15:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-28 14:49 [Qemu-devel] [Bug 942659] [NEW] ARM: CORTEX M, PRIMASK does not disable interrupts Oleksiy Bondarenko
2012-02-28 15:12 ` [Qemu-devel] [Bug 942659] " Peter Maydell
2012-02-28 15:15 ` Peter Maydell [this message]
2017-11-03 16:17 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120228151503.18562.8051.malone@soybean.canonical.com \
--to=peter.maydell@linaro.org \
--cc=942659@bugs.launchpad.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).