* [Qemu-devel] [Bug 942659] [NEW] ARM: CORTEX M, PRIMASK does not disable interrupts
@ 2012-02-28 14:49 Oleksiy Bondarenko
2012-02-28 15:12 ` [Qemu-devel] [Bug 942659] " Peter Maydell
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Oleksiy Bondarenko @ 2012-02-28 14:49 UTC (permalink / raw)
To: qemu-devel
Public bug reported:
qemu version 0.15.1
but the same code is in qemu 1.0
"CPSID I" does not disable interrupts for CORTEX M3
if (interrupt_request & CPU_INTERRUPT_HARD
&& ((IS_M(env) && env->regs[15] < 0xfffffff0)
|| !(env->uncached_cpsr & CPSR_I))) {
env->exception_index = EXCP_IRQ;
do_interrupt(env);
next_tb = 0;
}
do_interrupt() will be executed even if (env->uncached_cpsr & CPSR_I) == 1 , disable interrupt bit set.
then changed to:
if (interrupt_request & CPU_INTERRUPT_HARD
&& !(env->uncached_cpsr & CPSR_I)
&& (IS_M(env) ? env->regs[15] < 0xfffffff0: 1) ) {
env->exception_index = EXCP_IRQ;
do_interrupt(env);
next_tb = 0;
}
works
** Affects: qemu
Importance: Undecided
Status: New
** Tags: arm cortexm
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/942659
Title:
ARM: CORTEX M, PRIMASK does not disable interrupts
Status in QEMU:
New
Bug description:
qemu version 0.15.1
but the same code is in qemu 1.0
"CPSID I" does not disable interrupts for CORTEX M3
if (interrupt_request & CPU_INTERRUPT_HARD
&& ((IS_M(env) && env->regs[15] < 0xfffffff0)
|| !(env->uncached_cpsr & CPSR_I))) {
env->exception_index = EXCP_IRQ;
do_interrupt(env);
next_tb = 0;
}
do_interrupt() will be executed even if (env->uncached_cpsr & CPSR_I) == 1 , disable interrupt bit set.
then changed to:
if (interrupt_request & CPU_INTERRUPT_HARD
&& !(env->uncached_cpsr & CPSR_I)
&& (IS_M(env) ? env->regs[15] < 0xfffffff0: 1) ) {
env->exception_index = EXCP_IRQ;
do_interrupt(env);
next_tb = 0;
}
works
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/942659/+subscriptions
^ permalink raw reply [flat|nested] 4+ messages in thread* [Qemu-devel] [Bug 942659] Re: ARM: CORTEX M, PRIMASK does not disable interrupts
2012-02-28 14:49 [Qemu-devel] [Bug 942659] [NEW] ARM: CORTEX M, PRIMASK does not disable interrupts Oleksiy Bondarenko
@ 2012-02-28 15:12 ` Peter Maydell
2012-02-28 15:15 ` Peter Maydell
2017-11-03 16:17 ` Peter Maydell
2 siblings, 0 replies; 4+ messages in thread
From: Peter Maydell @ 2012-02-28 15:12 UTC (permalink / raw)
To: qemu-devel
This change changes the behaviour for non-M-profile cores, which looks
wrong.
See discussion in this mailing list thread where a similar patch was suggested:
http://lists.gnu.org/archive/html/qemu-devel/2011-06/msg00500.html
M profile interrupt handling is known-broken. I'm not accepting any
patches in this area unless they come attached to a decent explanation
of why they are the correct change to make and show some evidence of the
whole problem having been considered.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/942659
Title:
ARM: CORTEX M, PRIMASK does not disable interrupts
Status in QEMU:
New
Bug description:
qemu version 0.15.1
but the same code is in qemu 1.0
"CPSID I" does not disable interrupts for CORTEX M3
if (interrupt_request & CPU_INTERRUPT_HARD
&& ((IS_M(env) && env->regs[15] < 0xfffffff0)
|| !(env->uncached_cpsr & CPSR_I))) {
env->exception_index = EXCP_IRQ;
do_interrupt(env);
next_tb = 0;
}
do_interrupt() will be executed even if (env->uncached_cpsr & CPSR_I) == 1 , disable interrupt bit set.
then changed to:
if (interrupt_request & CPU_INTERRUPT_HARD
&& !(env->uncached_cpsr & CPSR_I)
&& (IS_M(env) ? env->regs[15] < 0xfffffff0: 1) ) {
env->exception_index = EXCP_IRQ;
do_interrupt(env);
next_tb = 0;
}
works
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/942659/+subscriptions
^ permalink raw reply [flat|nested] 4+ messages in thread* [Qemu-devel] [Bug 942659] Re: ARM: CORTEX M, PRIMASK does not disable interrupts
2012-02-28 14:49 [Qemu-devel] [Bug 942659] [NEW] ARM: CORTEX M, PRIMASK does not disable interrupts Oleksiy Bondarenko
2012-02-28 15:12 ` [Qemu-devel] [Bug 942659] " Peter Maydell
@ 2012-02-28 15:15 ` Peter Maydell
2017-11-03 16:17 ` Peter Maydell
2 siblings, 0 replies; 4+ messages in thread
From: Peter Maydell @ 2012-02-28 15:15 UTC (permalink / raw)
To: qemu-devel
> This change changes the behaviour for non-M-profile cores
...or maybe not: I was confused by the resemblance to that other patch.
I still think one-line fixes are unlikely to be the right approach here,
though.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/942659
Title:
ARM: CORTEX M, PRIMASK does not disable interrupts
Status in QEMU:
New
Bug description:
qemu version 0.15.1
but the same code is in qemu 1.0
"CPSID I" does not disable interrupts for CORTEX M3
if (interrupt_request & CPU_INTERRUPT_HARD
&& ((IS_M(env) && env->regs[15] < 0xfffffff0)
|| !(env->uncached_cpsr & CPSR_I))) {
env->exception_index = EXCP_IRQ;
do_interrupt(env);
next_tb = 0;
}
do_interrupt() will be executed even if (env->uncached_cpsr & CPSR_I) == 1 , disable interrupt bit set.
then changed to:
if (interrupt_request & CPU_INTERRUPT_HARD
&& !(env->uncached_cpsr & CPSR_I)
&& (IS_M(env) ? env->regs[15] < 0xfffffff0: 1) ) {
env->exception_index = EXCP_IRQ;
do_interrupt(env);
next_tb = 0;
}
works
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/942659/+subscriptions
^ permalink raw reply [flat|nested] 4+ messages in thread* [Qemu-devel] [Bug 942659] Re: ARM: CORTEX M, PRIMASK does not disable interrupts
2012-02-28 14:49 [Qemu-devel] [Bug 942659] [NEW] ARM: CORTEX M, PRIMASK does not disable interrupts Oleksiy Bondarenko
2012-02-28 15:12 ` [Qemu-devel] [Bug 942659] " Peter Maydell
2012-02-28 15:15 ` Peter Maydell
@ 2017-11-03 16:17 ` Peter Maydell
2 siblings, 0 replies; 4+ messages in thread
From: Peter Maydell @ 2017-11-03 16:17 UTC (permalink / raw)
To: qemu-devel
This long-standing bug has been fixed by the rewrite of the M-profile
exception handling for QEMU 2.9.
** Changed in: qemu
Status: New => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/942659
Title:
ARM: CORTEX M, PRIMASK does not disable interrupts
Status in QEMU:
Fix Released
Bug description:
qemu version 0.15.1
but the same code is in qemu 1.0
"CPSID I" does not disable interrupts for CORTEX M3
if (interrupt_request & CPU_INTERRUPT_HARD
&& ((IS_M(env) && env->regs[15] < 0xfffffff0)
|| !(env->uncached_cpsr & CPSR_I))) {
env->exception_index = EXCP_IRQ;
do_interrupt(env);
next_tb = 0;
}
do_interrupt() will be executed even if (env->uncached_cpsr & CPSR_I) == 1 , disable interrupt bit set.
then changed to:
if (interrupt_request & CPU_INTERRUPT_HARD
&& !(env->uncached_cpsr & CPSR_I)
&& (IS_M(env) ? env->regs[15] < 0xfffffff0: 1) ) {
env->exception_index = EXCP_IRQ;
do_interrupt(env);
next_tb = 0;
}
works
To manage notifications about this bug go to:
https://bugs.launchpad.net/qemu/+bug/942659/+subscriptions
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-11-03 16:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-28 14:49 [Qemu-devel] [Bug 942659] [NEW] ARM: CORTEX M, PRIMASK does not disable interrupts Oleksiy Bondarenko
2012-02-28 15:12 ` [Qemu-devel] [Bug 942659] " Peter Maydell
2012-02-28 15:15 ` Peter Maydell
2017-11-03 16:17 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).