From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33064) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2TAh-00059D-PO for qemu-devel@nongnu.org; Tue, 28 Feb 2012 14:57:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S2TAc-000888-Py for qemu-devel@nongnu.org; Tue, 28 Feb 2012 14:57:15 -0500 Received: from mx1.redhat.com ([209.132.183.28]:21683) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2TAc-00087v-HN for qemu-devel@nongnu.org; Tue, 28 Feb 2012 14:57:10 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1SJv8xW007503 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 28 Feb 2012 14:57:08 -0500 Date: Tue, 28 Feb 2012 16:57:10 -0300 From: Luiz Capitulino Message-ID: <20120228165710.4400f329@doriath.home> In-Reply-To: <1330118525-14522-1-git-send-email-alevy@redhat.com> References: <1330118525-14522-1-git-send-email-alevy@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/4] qapi-schema: fix typos and explain 'spice' auth List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alon Levy Cc: armbru@redhat.com, qemu-devel@nongnu.org, kraxel@redhat.com On Fri, 24 Feb 2012 23:22:02 +0200 Alon Levy wrote: > Signed-off-by: Alon Levy > --- > qapi-schema.json | 18 ++++++++++-------- > 1 files changed, 10 insertions(+), 8 deletions(-) > > diff --git a/qapi-schema.json b/qapi-schema.json > index d0b6792..72b17f1 100644 > --- a/qapi-schema.json > +++ b/qapi-schema.json > @@ -616,12 +616,13 @@ > # @connection-id: SPICE connection id number. All channels with the same id > # belong to the same SPICE session. > # > -# @connection-type: SPICE channel type number. "1" is the main control channel, > -# filter for this one if you want track spice sessions only > +# @connection-type: SPICE channel type number. "1" is the main control > +# channel, filter for this one if you want to track spice > +# sessions only > # > -# @channel-id: SPICE channel ID number. Usually "0", might be different needed > -# when multiple channels of the same type exist, such as multiple > -# display channels in a multihead setup > +# @channel-id: SPICE channel ID number. Usually "0", might be different when > +# multiple channels of the same type exist, such as multiple > +# display channels in a multihead setup > # > # @tls: true if the channel is encrypted, false otherwise. > # > @@ -649,8 +650,9 @@ > # @tls-port: #optional The SPICE server's TLS port number. > # > # @auth: #optional the current authentication type used by the server > -# 'none' if no authentication is being used > -# 'spice' (TODO: describe) > +# 'none' if no authentication is being used > +# 'spice' uses SASL or direct TLS authentication, depending on command > +# line options > # > # @channels: a list of @SpiceChannel for each active spice channel > # > @@ -1216,7 +1218,7 @@ > { 'command': 'migrate_set_speed', 'data': {'value': 'int'} } > > ## > -# @DevicePropertyInfo: > +# @ObjectPropertyInfo: > # > # @name: the name of the property > # This last hunk is unrelated to this series.