From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58036) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2TEc-0007k9-Ng for qemu-devel@nongnu.org; Tue, 28 Feb 2012 15:01:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S2TEV-0000M5-9M for qemu-devel@nongnu.org; Tue, 28 Feb 2012 15:01:18 -0500 Received: from mx1.redhat.com ([209.132.183.28]:7812) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2TEV-0000Ll-0M for qemu-devel@nongnu.org; Tue, 28 Feb 2012 15:01:11 -0500 Date: Tue, 28 Feb 2012 20:01:03 +0000 From: "Daniel P. Berrange" Message-ID: <20120228200102.GA20044@redhat.com> References: <1330443963-18547-1-git-send-email-yan@ravellosystems.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] VMXNET3 paravirtual NIC device implementation Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Izik Eidus Cc: Dmitry Fleytman , Yan Vugenfirer , Yan Vugenfirer , qemu-devel@nongnu.org On Tue, Feb 28, 2012 at 02:57:32PM -0500, Izik Eidus wrote: > On Tue, Feb 28, 2012 at 2:50 PM, Yan Vugenfirer wrote: > > Adding Izik from Ravello. > > > > Best regards, > > Yan. > > > > On Tue, Feb 28, 2012 at 6:43 PM, malc wrote: > >> On Tue, 28 Feb 2012, Yan Vugenfirer wrote: > >> > >>> From: Dmitry Fleytman > >>> > >>> Implementation of VMWare VMXNET3 paravirtual NIC device. > >>> Supports of all the device features including offload capabilties, > >>> VLANs and etc. > >>> The device is tested on different OSes: > >> [..snip..] > >> > >>> @@ -0,0 +1,146 @@ > >>> +/* > >>> + * QEMU VMWARE paravirtual devices - auxiliary code > >>> + * > >>> + * Copyright (c) 2012 Ravello Systems LTD (http://ravellosystems.c= om) > >>> + * All Rights Reserved > >> > >> Not quite sure, i'm follwing this, here it says that all rights are > >> reserved. >=20 >=20 > Hey, >=20 > isn`t this is the common GPL2 licence format? > for example from the very same qemu: > /* > * qemu/kvm integration > * > * Copyright (C) 2006-2008 Qumranet Technologies > * > * Licensed under the terms of the GNU GPL version 2 or higher. > */ >=20 > Do we miss anything? because our meaning is to publish it as a fully > GPL2 licensed code... Your "Copyright" line is fine, but you should really remove the 'All rights reserved' line which contradicts your GPL intention below > >> > >>> + * > >>> + * Developed by Daynix Computing LTD (http://www.daynix.com) > >>> + * > >>> + * Authors: > >>> + * Dmitry Fleytman > >>> + * Yan Vugenfirer > >>> + * > >>> + * This program is free software; you can redistribute it and/or m= odify it > >>> + * under the terms of the GNU General Public License as published = by the > >>> + * Free Software Foundation; version 2 of the License and no later= version. > >>> + * > >>> + * This program is distributed in the hope that it will be useful,= but > >>> + * WITHOUT ANY WARRANTY; without even the implied warranty of > >>> + * MERCHANTABILITY OR FITNESS FOR A PARTICULAR PURPOSE, GOOD TITLE= or > >>> + * NON INFRINGEMENT. =C2=A0See the GNU General Public License for = more > >>> + * details. > >>> + * > >>> + * You should have received a copy of the GNU General Public Licen= se > >>> + * along with this program; if not, write to the Free Software > >>> + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110= -1301 USA. > >>> + * > >>> + * The full GNU General Public License is included in this distrib= ution in > >>> + * the file called "COPYING". > >>> + * > >>> + */ > >> > >> And here that most of them are really not. > >> > >> Not a lawyer though. > >> > >> [..snip..] > >> > >> -- > >> mailto:av1474@comtv.ru >=20 Regards, Daniel --=20 |: http://berrange.com -o- http://www.flickr.com/photos/dberrange= / :| |: http://libvirt.org -o- http://virt-manager.or= g :| |: http://autobuild.org -o- http://search.cpan.org/~danberr= / :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vn= c :|