From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54855) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2hfM-0003N6-Eh for qemu-devel@nongnu.org; Wed, 29 Feb 2012 06:25:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S2hfK-00072o-0v for qemu-devel@nongnu.org; Wed, 29 Feb 2012 06:25:51 -0500 Received: from mx1.redhat.com ([209.132.183.28]:16261) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2hfJ-00072h-P6 for qemu-devel@nongnu.org; Wed, 29 Feb 2012 06:25:49 -0500 Date: Wed, 29 Feb 2012 13:25:52 +0200 From: "Michael S. Tsirkin" Message-ID: <20120229112552.GB5233@redhat.com> References: <20120228175914.GA28479@redhat.com> <4F4D1951.4040807@codemonkey.ws> <4F4D19C5.8030507@redhat.com> <4F4D2789.2070306@codemonkey.ws> <4F4D2848.30007@redhat.com> <4F4D290F.90907@codemonkey.ws> <20120228225805.GA8740@redhat.com> <4F4DF94A.80803@redhat.com> <20120229102306.GA4924@redhat.com> <4F4E03BE.0@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F4E03BE.0@redhat.com> Subject: Re: [Qemu-devel] [PULL] Memory core space reduction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: qemu-devel , Anthony Liguori On Wed, Feb 29, 2012 at 12:53:50PM +0200, Avi Kivity wrote: > On 02/29/2012 12:23 PM, Michael S. Tsirkin wrote: > > On Wed, Feb 29, 2012 at 12:09:14PM +0200, Avi Kivity wrote: > > > On 02/29/2012 12:58 AM, Michael S. Tsirkin wrote: > > > > > > > > What I did, to allow bisect, is rebase Avi's patches on top > > > > of my bridge implementation, then run qemu with a bridge. > > > > bridge without Avi's patches at least starts booting, with > > > > Avi's patches crashes before guest start. > > > > > > > > If you want to play with that, take it from branch bisectme > > > > on my qemu tree on github. > > > > > > > > > > How do you reproduce it? > > > > > > I tried > > > > > > qemu-system-x86_64 -device pci-bridge,chassis_nr=23 > > > > > > but that boots. > > > > It could be that you need more devices. This is my command line: > > qemu-system-x86_64 -m 1G -drive file=/home/mst/rhel6.qcow2 -netdev > > user,id=bar -net nic,netdev=bar,model=e1000,macaddr=52:54:00:12:34:57 > > -redir tcp:8022::22 -device pci-bridge,id=bog,chassis_nr=1 -netdev > > tap,id=foo,ifname=msttap0,script=/home/mst/ifup,downscript=no,vhost=on > > -nographic > > > > Boots too, even after supplying a peer to foo. > > I did get an abort with -enable-kvm, but that looks like the old issue, > no? Looking into it. > > Suggest a valgrind run. It does not crash under valgrind :) But valgrid did show some info: ==9202== Invalid write of size 8 ==9202== at 0x2F313D: portio_list_add_1 (ioport.c:379) ==9202== by 0x224473: parallel_isa_initfn (parallel.c:505) ==9202== by 0x274839: qdev_init (qdev.c:150) ==9202== by 0x3357F0: pc_basic_device_init (pc.h:53) ==9202== by 0x337DB2: pc_init1 (pc_piix.c:240) ==9202== by 0x3383E7: pc_init_pci (pc_piix.c:319) ==9202== by 0x24EFE7: main (vl.c:3397) ==9202== Address 0x27b202b8 is 0 bytes after a block of size 8 alloc'd ==9202== at 0x4A05FDE: malloc (vg_replace_malloc.c:236) ==9202== by 0x24D4C5: malloc_and_trace (vl.c:2156) ==9202== by 0x506334D: ??? (in /lib64/libglib-2.0.so.0.2200.5) ==9202== by 0x5063707: g_malloc0 (in /lib64/libglib-2.0.so.0.2200.5) ==9202== by 0x2F2FBC: portio_list_init (ioport.c:331) ==9202== by 0x21A545: isa_register_portio_list (isa-bus.c:109) ==9202== by 0x224473: parallel_isa_initfn (parallel.c:505) ==9202== by 0x274839: qdev_init (qdev.c:150) ==9202== by 0x3357F0: pc_basic_device_init (pc.h:53) ==9202== by 0x337DB2: pc_init1 (pc_piix.c:240) ==9202== by 0x3383E7: pc_init_pci (pc_piix.c:319) ==9202== by 0x24EFE7: main (vl.c:3397) ==9202== ==9202== Invalid write of size 8 ==9202== at 0x2F312F: portio_list_add_1 (ioport.c:378) ==9202== by 0x2064FA: isabus_fdc_init1 (fdc.c:1893) ==9202== by 0x274839: qdev_init (qdev.c:150) ==9202== by 0x27491C: qdev_init_nofail (qdev.c:243) ==9202== by 0x3358ED: pc_basic_device_init (fdc.h:25) ==9202== by 0x337DB2: pc_init1 (pc_piix.c:240) ==9202== by 0x3383E7: pc_init_pci (pc_piix.c:319) ==9202== by 0x24EFE7: main (vl.c:3397) ==9202== Address 0x28f54d20 is 0 bytes after a block of size 16 alloc'd ==9202== at 0x4A05FDE: malloc (vg_replace_malloc.c:236) ==9202== by 0x24D4C5: malloc_and_trace (vl.c:2156) ==9202== by 0x506334D: ??? (in /lib64/libglib-2.0.so.0.2200.5) ==9202== by 0x5063707: g_malloc0 (in /lib64/libglib-2.0.so.0.2200.5) ==9202== by 0x2F2FAB: portio_list_init (ioport.c:330) ==9202== by 0x21A545: isa_register_portio_list (isa-bus.c:109) ==9202== by 0x2064FA: isabus_fdc_init1 (fdc.c:1893) ==9202== by 0x274839: qdev_init (qdev.c:150) ==9202== by 0x27491C: qdev_init_nofail (qdev.c:243) ==9202== by 0x3358ED: pc_basic_device_init (fdc.h:25) ==9202== by 0x337DB2: pc_init1 (pc_piix.c:240) ==9202== by 0x3383E7: pc_init_pci (pc_piix.c:319) ==9202== ==9202== Invalid write of size 8 ==9202== at 0x2F313D: portio_list_add_1 (ioport.c:379) ==9202== by 0x2064FA: isabus_fdc_init1 (fdc.c:1893) ==9202== by 0x274839: qdev_init (qdev.c:150) ==9202== by 0x27491C: qdev_init_nofail (qdev.c:243) ==9202== by 0x3358ED: pc_basic_device_init (fdc.h:25) ==9202== by 0x337DB2: pc_init1 (pc_piix.c:240) ==9202== by 0x3383E7: pc_init_pci (pc_piix.c:319) ==9202== by 0x24EFE7: main (vl.c:3397) ==9202== Address 0x27b2ec78 is 8 bytes after a block of size 16 alloc'd ==9202== at 0x4A05FDE: malloc (vg_replace_malloc.c:236) ==9202== by 0x24D4C5: malloc_and_trace (vl.c:2156) ==9202== by 0x506334D: ??? (in /lib64/libglib-2.0.so.0.2200.5) ==9202== by 0x5063707: g_malloc0 (in /lib64/libglib-2.0.so.0.2200.5) ==9202== by 0x2F2FBC: portio_list_init (ioport.c:331) ==9202== by 0x21A545: isa_register_portio_list (isa-bus.c:109) ==9202== by 0x2064FA: isabus_fdc_init1 (fdc.c:1893) ==9202== by 0x274839: qdev_init (qdev.c:150) ==9202== by 0x27491C: qdev_init_nofail (qdev.c:243) ==9202== by 0x3358ED: pc_basic_device_init (fdc.h:25) ==9202== by 0x337DB2: pc_init1 (pc_piix.c:240) ==9202== by 0x3383E7: pc_init_pci (pc_piix.c:319) ==9202== ==9202== Invalid write of size 8 ==9202== at 0x2F313D: portio_list_add_1 (ioport.c:379) ==9202== by 0x2169EF: pci_piix_ide_initfn (piix.c:137) ==9202== by 0x2269DD: pci_qdev_init (pci.c:1492) ==9202== by 0x274839: qdev_init (qdev.c:150) ==9202== by 0x27491C: qdev_init_nofail (qdev.c:243) ==9202== by 0x225DD7: pci_create_simple_multifunction (pci.c:1552) ==9202== by 0x216C7E: pci_piix3_ide_init (piix.c:224) ==9202== by 0x338036: pc_init1 (pc_piix.c:257) ==9202== by 0x3383E7: pc_init_pci (pc_piix.c:319) ==9202== by 0x24EFE7: main (vl.c:3397) ==9202== Address 0x28fc30a8 is 0 bytes after a block of size 8 alloc'd ==9202== at 0x4A05FDE: malloc (vg_replace_malloc.c:236) ==9202== by 0x24D4C5: malloc_and_trace (vl.c:2156) ==9202== by 0x506334D: ??? (in /lib64/libglib-2.0.so.0.2200.5) ==9202== by 0x5063707: g_malloc0 (in /lib64/libglib-2.0.so.0.2200.5) ==9202== by 0x2F2FBC: portio_list_init (ioport.c:331) ==9202== by 0x21A545: isa_register_portio_list (isa-bus.c:109) ==9202== by 0x2169EF: pci_piix_ide_initfn (piix.c:137) ==9202== by 0x2269DD: pci_qdev_init (pci.c:1492) ==9202== by 0x274839: qdev_init (qdev.c:150) ==9202== by 0x27491C: qdev_init_nofail (qdev.c:243) ==9202== by 0x225DD7: pci_create_simple_multifunction (pci.c:1552) ==9202== by 0x216C7E: pci_piix3_ide_init (piix.c:224) ==9202== = Investigating. > -- > error compiling committee.c: too many arguments to function