From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:39329)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1S2kfk-0007ag-DL
	for qemu-devel@nongnu.org; Wed, 29 Feb 2012 09:38:34 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1S2kfe-0003z1-3Y
	for qemu-devel@nongnu.org; Wed, 29 Feb 2012 09:38:27 -0500
Received: from mx1.redhat.com ([209.132.183.28]:42705)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1S2kfd-0003yv-Ra
	for qemu-devel@nongnu.org; Wed, 29 Feb 2012 09:38:22 -0500
Received: from int-mx10.intmail.prod.int.phx2.redhat.com
	(int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q1TEcK0V000783
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Wed, 29 Feb 2012 09:38:20 -0500
Date: Wed, 29 Feb 2012 11:38:22 -0300
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20120229113822.3c479757@doriath.home>
In-Reply-To: <20120228205144.GC8200@garlic>
References: <1330118525-14522-1-git-send-email-alevy@redhat.com>
	<1330118525-14522-3-git-send-email-alevy@redhat.com>
	<20120228170113.1a5d59c6@doriath.home>
	<20120228205144.GC8200@garlic>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 3/4] monitor,
	console: add QEVENT_SCREEN_DUMP_COMPLETE
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alon Levy <alevy@redhat.com>
Cc: armbru@redhat.com, qemu-devel@nongnu.org, kraxel@redhat.com

On Tue, 28 Feb 2012 22:51:44 +0200
Alon Levy <alevy@redhat.com> wrote:

> On Tue, Feb 28, 2012 at 05:01:13PM -0300, Luiz Capitulino wrote:
> > On Fri, 24 Feb 2012 23:22:04 +0200
> > Alon Levy <alevy@redhat.com> wrote:
> > 
> > > Signed-off-by: Alon Levy <alevy@redhat.com>
> > > ---
> > >  QMP/qmp-events.txt |   14 ++++++++++++++
> > >  console.c          |   18 ++++++++++++++++++
> > >  console.h          |    1 +
> > >  monitor.c          |    2 ++
> > >  monitor.h          |    1 +
> > >  5 files changed, 36 insertions(+), 0 deletions(-)
> > > 
> > > diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt
> > > index 9286af5..0d1c9f4 100644
> > > --- a/QMP/qmp-events.txt
> > > +++ b/QMP/qmp-events.txt
> > > @@ -335,3 +335,17 @@ Example:
> > >                 "len": 10737418240, "offset": 134217728,
> > >                 "speed": 0 },
> > >       "timestamp": { "seconds": 1267061043, "microseconds": 959568 } }
> > > +
> > > +SCREEN_DUMP_COMPLETE
> > > +--------------------
> > > +
> > > +Emitted when screen-dump-async completes.
> > > +
> > > +Data:
> > > +
> > > +- "filename": Name of file containing screen dump (json-string)
> > > +
> > > +Example:
> > > +
> > > +{ "event": "SCREEN_DUMP_COMPLETE",
> > > +     "data": { "filename": "/tmp/a.ppm" } }
> > 
> > This example is incomplete, a QMP event contains more fields.
> 
> timestamp, right?

Yes.