From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52804) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2l1x-0006QI-TN for qemu-devel@nongnu.org; Wed, 29 Feb 2012 10:01:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S2l1q-0000Nr-Cc for qemu-devel@nongnu.org; Wed, 29 Feb 2012 10:01:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:63409) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S2l1q-0000Nb-4x for qemu-devel@nongnu.org; Wed, 29 Feb 2012 10:01:18 -0500 Date: Wed, 29 Feb 2012 12:01:16 -0300 From: Luiz Capitulino Message-ID: <20120229120116.533bd612@doriath.home> In-Reply-To: <4F4E2580.70706@redhat.com> References: <2c332c139b3d6b38e2ef93e2efc951f8565c4a52.1329649806.git.mprivozn@redhat.com> <20120223122034.728c259c@doriath.home> <4F4BD034.5030400@redhat.com> <20120228020728.GB2725@illuin> <20120228112222.31482e44@doriath.home> <20120228170938.GC2725@illuin> <20120228144142.71dd6641@doriath.home> <4F4E2580.70706@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v4] qemu-ga: Add guest-network-info command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michal Privoznik Cc: Michael Roth , qemu-devel@nongnu.org On Wed, 29 Feb 2012 14:17:52 +0100 Michal Privoznik wrote: > On 28.02.2012 18:41, Luiz Capitulino wrote: > >> Hmm, I know Michal already sent a new version with my suggestions, but > >> > you're right, splitting out the commands simplified both the responses, > >> > and makes it easier to discover whether or not that information is > >> > available, since you can look for the command in guest-info before > >> > attempting it, rather than attempting it and then looking at the result. > >> > > >> > So maybe just something this?: > >> > > >> > { 'type': 'GuestNetworkInterface', > >> > 'data': { 'name': 'str', > >> > '*hardware-address': 'str', > >> > '*ip-addresses': ['GuestIpAddress'] } } } > >> > > >> > { 'command': 'guest-network-interfaces', > >> > 'returns': ['GuestNetworkInterface'] } > > Looks good to me, the only nitpick is that I think command names should be > > verbs. > > guest-get-network-interfaces? Works for me, but would be good to agree on a standard for it. I'll defer the decision to Michael, as he's the actual maintainer :)