From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:55697)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1S2kJU-0007j8-De
	for qemu-devel@nongnu.org; Wed, 29 Feb 2012 09:15:37 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1S2kJK-0007mp-J1
	for qemu-devel@nongnu.org; Wed, 29 Feb 2012 09:15:27 -0500
Received: from mx1.redhat.com ([209.132.183.28]:42149)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mst@redhat.com>) id 1S2kJK-0007mH-AR
	for qemu-devel@nongnu.org; Wed, 29 Feb 2012 09:15:18 -0500
Date: Wed, 29 Feb 2012 16:15:20 +0200
From: "Michael S. Tsirkin" <mst@redhat.com>
Message-ID: <20120229141520.GB6945@redhat.com>
References: <4F4D2789.2070306@codemonkey.ws> <4F4D2848.30007@redhat.com>
	<4F4D290F.90907@codemonkey.ws> <20120228225805.GA8740@redhat.com>
	<4F4DF94A.80803@redhat.com> <20120229102306.GA4924@redhat.com>
	<4F4E03BE.0@redhat.com> <20120229112552.GB5233@redhat.com>
	<4F4E0C8A.9040902@redhat.com> <4F4E0FED.8040301@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4F4E0FED.8040301@redhat.com>
Subject: Re: [Qemu-devel] [PULL] Memory core space reduction
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>, Anthony Liguori <anthony@codemonkey.ws>

On Wed, Feb 29, 2012 at 01:45:49PM +0200, Avi Kivity wrote:
> On 02/29/2012 01:31 PM, Avi Kivity wrote:
> > On 02/29/2012 01:25 PM, Michael S. Tsirkin wrote:
> > > It does not crash under valgrind :)
> > > But valgrid did show some info:
> > >
> > > ==9202== Invalid write of size 8
> > > ==9202==    at 0x2F313D: portio_list_add_1 (ioport.c:379)
> > >
> >
> > Anthony, your "bad bisect" was in fact good - it was the very first
> > patch that was bad:
> >
> >     piolist->regions[piolist->nr++] = region;
> >     piolist->aliases[piolist->nr++] = alias;
> >
> > will fix.
> >
> 
> Please retry with the new memory/core branch I just pushed.  If using
> kvm, also apply the patch I posted elsewhere in this thread.

Yes, seems to boot now.

> -- 
> error compiling committee.c: too many arguments to function