From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:40177)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1S2lW1-0006tH-AQ
	for qemu-devel@nongnu.org; Wed, 29 Feb 2012 10:32:35 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1S2lVv-0007a2-0n
	for qemu-devel@nongnu.org; Wed, 29 Feb 2012 10:32:28 -0500
Received: from mail-pz0-f46.google.com ([209.85.210.46]:64882)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1S2lVu-0007Zf-Np
	for qemu-devel@nongnu.org; Wed, 29 Feb 2012 10:32:22 -0500
Received: by dajr28 with SMTP id r28so639502daj.33
	for <qemu-devel@nongnu.org>; Wed, 29 Feb 2012 07:32:19 -0800 (PST)
Sender: fluxion <flukshun@gmail.com>
Date: Wed, 29 Feb 2012 09:32:13 -0600
From: Michael Roth <mdroth@linux.vnet.ibm.com>
Message-ID: <20120229153213.GA4269@illuin>
References: <2c332c139b3d6b38e2ef93e2efc951f8565c4a52.1329649806.git.mprivozn@redhat.com>
	<20120223122034.728c259c@doriath.home>
	<4F4BD034.5030400@redhat.com> <20120228020728.GB2725@illuin>
	<20120228112222.31482e44@doriath.home>
	<20120228170938.GC2725@illuin>
	<20120228144142.71dd6641@doriath.home> <4F4E2580.70706@redhat.com>
	<20120229120116.533bd612@doriath.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20120229120116.533bd612@doriath.home>
Subject: Re: [Qemu-devel] [PATCH v4] qemu-ga: Add guest-network-info command
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: Michal Privoznik <mprivozn@redhat.com>, qemu-devel@nongnu.org

On Wed, Feb 29, 2012 at 12:01:16PM -0300, Luiz Capitulino wrote:
> On Wed, 29 Feb 2012 14:17:52 +0100
> Michal Privoznik <mprivozn@redhat.com> wrote:
> 
> > On 28.02.2012 18:41, Luiz Capitulino wrote:
> > >> Hmm, I know Michal already sent a new version with my suggestions, but
> > >> > you're right, splitting out the commands simplified both the responses,
> > >> > and makes it easier to discover whether or not that information is
> > >> > available, since you can look for the command in guest-info before
> > >> > attempting it, rather than attempting it and then looking at the result.
> > >> > 
> > >> > So maybe just something this?:
> > >> > 
> > >> > { 'type': 'GuestNetworkInterface',
> > >> >   'data': { 'name': 'str',
> > >> >             '*hardware-address': 'str',
> > >> >             '*ip-addresses': ['GuestIpAddress'] } } }
> > >> > 
> > >> > { 'command': 'guest-network-interfaces',
> > >> >   'returns': ['GuestNetworkInterface'] }
> > > Looks good to me, the only nitpick is that I think command names should be
> > > verbs.
> > 
> > guest-get-network-interfaces?
> 
> Works for me, but would be good to agree on a standard for it. I'll defer
> the decision to Michael, as he's the actual maintainer :)

I would prefer "guest-network-get-interfaces" since it's more in keeping
with the guest-file-* and guest-fsfreeze-* commands, but other than
that, looks good.

>