From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54932) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S33WP-0006q4-Fl for qemu-devel@nongnu.org; Thu, 01 Mar 2012 05:46:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S33Vx-0006IA-Sw for qemu-devel@nongnu.org; Thu, 01 Mar 2012 05:46:05 -0500 Received: from mx1.redhat.com ([209.132.183.28]:8413) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S33Vx-0006Hy-KD for qemu-devel@nongnu.org; Thu, 01 Mar 2012 05:45:37 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q21AjZIa003330 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 1 Mar 2012 05:45:35 -0500 Date: Thu, 1 Mar 2012 12:45:30 +0200 From: Alon Levy Message-ID: <20120301104530.GR15718@garlic.tlv.redhat.com> References: <1330587280-13038-1-git-send-email-kraxel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1330587280-13038-1-git-send-email-kraxel@redhat.com> Subject: Re: [Qemu-devel] [PATCH] fix screendump List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org On Thu, Mar 01, 2012 at 08:34:40AM +0100, Gerd Hoffmann wrote: > Commit 45efb16124efef51de5157afc31984b5a47700f9 optimized a bit too > much. We can skip the vga_invalidate_display() in case no console > switch happened because we don't need a full redraw then. We can *not* > skip vga_hw_update() though, because the screen content will be stale > then in case nobody else calls vga_hw_update(). > > Trigger: vga textmode with vnc display and no client connected. > Reviewed-by: Alon Levy > Reported-by: Avi Kivity > Signed-off-by: Gerd Hoffmann > --- > hw/blizzard.c | 4 +--- > hw/omap_lcdc.c | 5 ++--- > hw/vga.c | 2 +- > 3 files changed, 4 insertions(+), 7 deletions(-) > > diff --git a/hw/blizzard.c b/hw/blizzard.c > index c7d844d..29074c4 100644 > --- a/hw/blizzard.c > +++ b/hw/blizzard.c > @@ -937,9 +937,7 @@ static void blizzard_screen_dump(void *opaque, const char *filename, > { > BlizzardState *s = (BlizzardState *) opaque; > > - if (cswitch) { > - blizzard_update_display(opaque); > - } > + blizzard_update_display(opaque); > if (s && ds_get_data(s->state)) > ppm_save(filename, s->state->surface); > } > diff --git a/hw/omap_lcdc.c b/hw/omap_lcdc.c > index f172093..4a08e9d 100644 > --- a/hw/omap_lcdc.c > +++ b/hw/omap_lcdc.c > @@ -267,9 +267,8 @@ static int ppm_save(const char *filename, uint8_t *data, > static void omap_screen_dump(void *opaque, const char *filename, bool cswitch) > { > struct omap_lcd_panel_s *omap_lcd = opaque; > - if (cswitch) { > - omap_update_display(opaque); > - } > + > + omap_update_display(opaque); > if (omap_lcd && ds_get_data(omap_lcd->state)) > ppm_save(filename, ds_get_data(omap_lcd->state), > omap_lcd->width, omap_lcd->height, > diff --git a/hw/vga.c b/hw/vga.c > index 5994f43..16546ef 100644 > --- a/hw/vga.c > +++ b/hw/vga.c > @@ -2413,7 +2413,7 @@ static void vga_screen_dump(void *opaque, const char *filename, bool cswitch) > > if (cswitch) { > vga_invalidate_display(s); > - vga_hw_update(); > } > + vga_hw_update(); > ppm_save(filename, s->ds->surface); > } > -- > 1.7.1 > >