From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44707) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S34PQ-0002N2-AA for qemu-devel@nongnu.org; Thu, 01 Mar 2012 06:43:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S34P2-0001x7-90 for qemu-devel@nongnu.org; Thu, 01 Mar 2012 06:42:55 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47496) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S34P2-0001wo-1A for qemu-devel@nongnu.org; Thu, 01 Mar 2012 06:42:32 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q21BgUV2005743 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 1 Mar 2012 06:42:30 -0500 Date: Thu, 1 Mar 2012 17:12:26 +0530 From: Amit Shah Message-ID: <20120301114226.GH2903@amit.redhat.com> References: <1330601288-3558-1-git-send-email-owasserm@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1330601288-3558-1-git-send-email-owasserm@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2] We should check the virtio_load return code List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Orit Wasserman Cc: pbonzini@redhat.com, Ulrich Obergfell , qemu-devel@nongnu.org, armbru@redhat.com, mst@redhat.com On (Thu) 01 Mar 2012 [13:28:08], Orit Wasserman wrote: > Otherwise we crash on error. > Instruction to reporduce the crash with migration: > 1) run a guest with -device virtio-blk-pci,drive=drive_name,scsi=on > 2) run destination with > -device virtio-blk-pci,drive=drive_name,scsi=off ... -incoming ... > 3) migrate from 1 to 2. Thanks. Acked-by: Amit Shah Amit