From: Luiz Capitulino <lcapitulino@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: kwolf@redhat.com, aliguori@us.ibm.com,
stefanha@linux.vnet.ibm.com, jcody@redhat.com,
qemu-devel@nongnu.org, fsimonce@redhat.com, eblake@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 0/6] Mirrored writes using blockdev-transaction
Date: Thu, 1 Mar 2012 13:02:50 -0300 [thread overview]
Message-ID: <20120301130250.46c2377e@doriath.home> (raw)
In-Reply-To: <1330600908-16202-1-git-send-email-pbonzini@redhat.com>
On Thu, 1 Mar 2012 12:21:42 +0100
Paolo Bonzini <pbonzini@redhat.com> wrote:
> This implements all ingredients to establish mirrored writes.
This looks good to me. I just have two comments:
1. I'm wondering if it would make more sense to have this transaction
operation in qmp instead of the block layer. Looks more complex to do though,
so I'm ok with this implementation
2. Anthony had a different proposal for this and would be good to get input
from him. I pinged him on irc and he said he will try to review this series
later today
next prev parent reply other threads:[~2012-03-01 16:03 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-01 11:21 [Qemu-devel] [PATCH v2 0/6] Mirrored writes using blockdev-transaction Paolo Bonzini
2012-03-01 11:21 ` [Qemu-devel] [PATCH v2 1/6] fix format name for backing file Paolo Bonzini
2012-03-01 11:21 ` [Qemu-devel] [PATCH v2 2/6] qapi: complete implementation of unions Paolo Bonzini
2012-03-01 13:52 ` Kevin Wolf
2012-03-01 15:56 ` Luiz Capitulino
2012-03-01 11:21 ` [Qemu-devel] [PATCH v2 3/6] rename blockdev-group-snapshot-sync Paolo Bonzini
2012-03-01 11:21 ` [Qemu-devel] [PATCH v2 4/6] add reuse field Paolo Bonzini
2012-03-01 11:21 ` [Qemu-devel] [PATCH v2 5/6] Add blkmirror block driver Paolo Bonzini
2012-03-01 11:21 ` [Qemu-devel] [PATCH v2 6/6] add mirroring to blockdev-transaction Paolo Bonzini
2012-03-01 16:02 ` Luiz Capitulino [this message]
2012-03-01 16:18 ` [Qemu-devel] [PATCH v2 0/6] Mirrored writes using blockdev-transaction Kevin Wolf
2012-03-01 16:43 ` Luiz Capitulino
2012-03-01 21:10 ` Anthony Liguori
2012-03-01 21:30 ` Eric Blake
2012-03-01 21:36 ` Anthony Liguori
2012-03-02 13:05 ` Anthony Liguori
2012-03-05 8:53 ` Kevin Wolf
2012-03-05 9:28 ` Paolo Bonzini
2012-03-05 12:13 ` Kevin Wolf
2012-03-05 13:05 ` Paolo Bonzini
2012-03-05 14:47 ` Anthony Liguori
2012-03-05 14:54 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120301130250.46c2377e@doriath.home \
--to=lcapitulino@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=eblake@redhat.com \
--cc=fsimonce@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).