From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43293) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S38TD-0000Fl-Ma for qemu-devel@nongnu.org; Thu, 01 Mar 2012 11:03:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S38T4-0005q4-NY for qemu-devel@nongnu.org; Thu, 01 Mar 2012 11:03:07 -0500 Received: from mx1.redhat.com ([209.132.183.28]:25277) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S38T4-0005po-FX for qemu-devel@nongnu.org; Thu, 01 Mar 2012 11:02:58 -0500 Date: Thu, 1 Mar 2012 13:02:50 -0300 From: Luiz Capitulino Message-ID: <20120301130250.46c2377e@doriath.home> In-Reply-To: <1330600908-16202-1-git-send-email-pbonzini@redhat.com> References: <1330600908-16202-1-git-send-email-pbonzini@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/6] Mirrored writes using blockdev-transaction List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, aliguori@us.ibm.com, stefanha@linux.vnet.ibm.com, jcody@redhat.com, qemu-devel@nongnu.org, fsimonce@redhat.com, eblake@redhat.com On Thu, 1 Mar 2012 12:21:42 +0100 Paolo Bonzini wrote: > This implements all ingredients to establish mirrored writes. This looks good to me. I just have two comments: 1. I'm wondering if it would make more sense to have this transaction operation in qmp instead of the block layer. Looks more complex to do though, so I'm ok with this implementation 2. Anthony had a different proposal for this and would be good to get input from him. I pinged him on irc and he said he will try to review this series later today