From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:42827)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1S3Uya-0003m9-D7
	for qemu-devel@nongnu.org; Fri, 02 Mar 2012 11:05:06 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1S3UyU-0000YV-5P
	for qemu-devel@nongnu.org; Fri, 02 Mar 2012 11:04:59 -0500
Received: from mx1.redhat.com ([209.132.183.28]:10872)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1S3UyT-0000Y8-Th
	for qemu-devel@nongnu.org; Fri, 02 Mar 2012 11:04:54 -0500
Date: Fri, 2 Mar 2012 18:04:45 +0200
From: Alon Levy <alevy@redhat.com>
Message-ID: <20120302160445.GD22523@garlic>
References: <1330692562-21943-1-git-send-email-marcandre.lureau@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
In-Reply-To: <1330692562-21943-1-git-send-email-marcandre.lureau@redhat.com>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] spice: set spice uuid and name
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?iso-8859-1?Q?Marc-Andr=E9?= Lureau <marcandre.lureau@gmail.com>
Cc: =?iso-8859-1?Q?Marc-Andr=E9?= Lureau <marcandre.lureau@redhat.com>, qemu-devel@nongnu.org

On Fri, Mar 02, 2012 at 01:49:22PM +0100, Marc-Andr=E9 Lureau wrote:
> This allows a Spice client to identify a VM

My only problem with this is that if we have a monitor vmcchannel you
could issue the command to query that, and much more, without having to
add any messages. And adding a monitor channel is really easy - the only
requirement being that qemu can handle two monitor users, libvirt and
spice.

> ---
>  ui/spice-core.c |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
>=20
> diff --git a/ui/spice-core.c b/ui/spice-core.c
> index 1308a3d..8472cdd 100644
> --- a/ui/spice-core.c
> +++ b/ui/spice-core.c
> @@ -19,6 +19,7 @@
>  #include <spice-experimental.h>
> =20
>  #include <netdb.h>
> +#include "sysemu.h"
> =20
>  #include "qemu-common.h"
>  #include "qemu-spice.h"
> @@ -699,6 +700,11 @@ void qemu_spice_init(void)
> =20
>      qemu_opt_foreach(opts, add_channel, NULL, 0);
> =20
> +#if SPICE_SERVER_VERSION >=3D 0x000a02 /* 0.10.2 */
> +    spice_server_set_name(spice_server, qemu_name);
> +    spice_server_set_uuid(spice_server, qemu_uuid);
> +#endif
> +
>      if (0 !=3D spice_server_init(spice_server, &core_interface)) {
>          fprintf(stderr, "failed to initialize spice server");
>          exit(1);
> --=20
> 1.7.7.6
>=20
>=20