From: Paul Brook <paul@codesourcery.com>
To: Alexander Graf <agraf@suse.de>
Cc: "Bernhard M. Wiedemann" <bwiedemann@suse.de>,
Riku Voipio <riku.voipio@iki.fi>,
qemu-devel qemu-devel <qemu-devel@nongnu.org>,
Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH] linux-user: map at TARGET_UNMAPPED_BASE with reserved_va
Date: Sun, 4 Mar 2012 00:33:25 +0000 [thread overview]
Message-ID: <201203040033.26488.paul@codesourcery.com> (raw)
In-Reply-To: <1330813157-11793-1-git-send-email-agraf@suse.de>
> When mmap()'ing memory somewhere where it's not allowed, we should not
> default to the "next free page" which could be right after brk()'ed memory,
> but rather at TARGET_UNMAPPED_BASE, which ensures that brk() can extend its
> space later on.
NACK, As discussed on IRC.
Effectively prevents mmap from allocating below TARGET_UNMAPPED_BASE.
This wastes a lot of perfectly good address space. With small -R values it
leaves mmap with no usable virtual address space.
Paul
prev parent reply other threads:[~2012-03-04 0:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-03 22:19 [Qemu-devel] [PATCH] linux-user: map at TARGET_UNMAPPED_BASE with reserved_va Alexander Graf
2012-03-04 0:33 ` Paul Brook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201203040033.26488.paul@codesourcery.com \
--to=paul@codesourcery.com \
--cc=agraf@suse.de \
--cc=bwiedemann@suse.de \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).