From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50504) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S3zOI-0007t3-9P for qemu-devel@nongnu.org; Sat, 03 Mar 2012 19:33:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S3zOG-0008EC-KD for qemu-devel@nongnu.org; Sat, 03 Mar 2012 19:33:33 -0500 Received: from relay1.mentorg.com ([192.94.38.131]:59813) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S3zOG-0008E7-EI for qemu-devel@nongnu.org; Sat, 03 Mar 2012 19:33:32 -0500 From: Paul Brook Date: Sun, 4 Mar 2012 00:33:25 +0000 References: <1330813157-11793-1-git-send-email-agraf@suse.de> In-Reply-To: <1330813157-11793-1-git-send-email-agraf@suse.de> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-6" Content-Transfer-Encoding: 7bit Message-Id: <201203040033.26488.paul@codesourcery.com> Subject: Re: [Qemu-devel] [PATCH] linux-user: map at TARGET_UNMAPPED_BASE with reserved_va List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: "Bernhard M. Wiedemann" , Riku Voipio , qemu-devel qemu-devel , Peter Maydell > When mmap()'ing memory somewhere where it's not allowed, we should not > default to the "next free page" which could be right after brk()'ed memory, > but rather at TARGET_UNMAPPED_BASE, which ensures that brk() can extend its > space later on. NACK, As discussed on IRC. Effectively prevents mmap from allocating below TARGET_UNMAPPED_BASE. This wastes a lot of perfectly good address space. With small -R values it leaves mmap with no usable virtual address space. Paul