qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, Anthony Liguori <anthony@codemonkey.ws>
Subject: Re: [Qemu-devel] [PATCH] make: remove generated objects from target dirs
Date: Sun, 4 Mar 2012 16:13:47 +0200	[thread overview]
Message-ID: <20120304141346.GB12776@redhat.com> (raw)
In-Reply-To: <CAFEAcA-ZHg0GmOcTqOTop=eTM1yEqKj2k_41-TD3v7YsiAu+uA@mail.gmail.com>

On Sun, Mar 04, 2012 at 01:44:26PM +0000, Peter Maydell wrote:
> On 4 March 2012 13:31, Michael S. Tsirkin <mst@redhat.com> wrote:
> > On Sun, Mar 04, 2012 at 01:25:59PM +0000, Peter Maydell wrote:
> >> In general we don't have workarounds for "something
> >> moved directory and this broke builds not from clean"
> >
> > Why don't we? It's cheaper than always doing
> > make clean after pull.
> 
> That's an argument for a general solution to the problem,
> not a one-off bandaid fix for the bit that happened to
> bite you.

What I did is generic: I remove all generated headers.
If you see more problems, let me know.

> >> (source file moved from hw/ to . being one that's bitten
> >> me before),
> >
> > Why would that bite anyone? AFAIK files under source control
> > are handled fine. It's the generated ones that are
> > a problem.
> 
> I forget the exact failure mode but I think the problem
> is that the old arm-softmmu/foo.d file is still lying
> around and claims that foo.o depends on the no-longer-present
> hw/foo.c. (If we didn't squash the directory structure, so
> that it was arm-softmmu/hw/foo.d and arm-softmmu/hw/foo.o,
> this problem wouldn't happen.)
> 
> -- PMM

Aha. A stale .d file, I see. Note that it's
siginificantly different from my problem. I would think if
.c is newer than .o we should just ignore .d,
alternatively make the dependencies in .d somehow weaker
than the implicit dependencies so they don't fail the build.
I'll see whether I can come up with a solution.

-- 
MST

  reply	other threads:[~2012-03-04 14:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-04  9:10 [Qemu-devel] [PATCH] make: remove generated objects from target dirs Michael S. Tsirkin
2012-03-04 13:25 ` Peter Maydell
2012-03-04 13:31   ` Michael S. Tsirkin
2012-03-04 13:44     ` Peter Maydell
2012-03-04 14:13       ` Michael S. Tsirkin [this message]
2012-03-04 16:03 ` Andreas Färber
2012-03-04 16:49   ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120304141346.GB12776@redhat.com \
    --to=mst@redhat.com \
    --cc=anthony@codemonkey.ws \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).