qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Amos Kong <akong@redhat.com>
To: aliguori@us.ibm.com, kvm@vger.kernel.org, quintela@redhat.com,
	jasowang@redhat.com, qemu-devel@nongnu.org, laine@redhat.com
Subject: [Qemu-devel] [PATCH v2 9/9] net: support to include ipv6 address by brackets
Date: Mon, 05 Mar 2012 18:04:32 +0800	[thread overview]
Message-ID: <20120305100432.3595.19757.stgit@dhcp-8-167.nay.redhat.com> (raw)
In-Reply-To: <20120305095934.3595.88531.stgit@dhcp-8-167.nay.redhat.com>

That method of representing an IPv6 address with a port is
discouraged because of its ambiguity. Referencing to RFC5952,
the recommended format is:

     [2312::8274]:5200

For IPv6 brackets must be mandatory if you require a port.

test status: Successed
listen side: qemu-kvm .... -incoming tcp:[2312::8274]:5200
client side: qemu-kvm ...
             (qemu) migrate -d tcp:[2312::8274]:5200

Signed-off-by: Amos Kong <akong@redhat.com>
---
 net.c |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)

diff --git a/net.c b/net.c
index d6ce1fa..499ed1d 100644
--- a/net.c
+++ b/net.c
@@ -88,6 +88,12 @@ static int get_str_sep(char *buf, int buf_size, const char **pp, int sep)
     if (!p1)
         return -1;
     len = p1 - p;
+    /* remove brackets which includes hostname */
+    if (*p == '[' && *(p1-1) == ']') {
+        p += 1;
+        len -= 2;
+    }
+
     p1++;
     if (buf_size > 0) {
         if (len > buf_size - 1)

      parent reply	other threads:[~2012-03-05 10:04 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-05 10:03 [Qemu-devel] [PATCH v2 0/9] support to migrate with IPv6 address Amos Kong
2012-03-05 10:03 ` [Qemu-devel] [PATCH v2 1/9] net: introduce tcp_server_start() Amos Kong
2012-03-05 13:25   ` Orit Wasserman
2012-03-05 13:49     ` Amos Kong
2012-03-05 10:03 ` [Qemu-devel] [PATCH v2 2/9] net: use tcp_server_start() for tcp server creation Amos Kong
2012-03-05 13:27   ` Orit Wasserman
2012-03-05 13:44     ` Amos Kong
2012-03-05 10:03 ` [Qemu-devel] [PATCH v2 3/9] net: introduce tcp_client_start() Amos Kong
2012-03-05 13:26   ` Orit Wasserman
2012-03-05 13:36   ` Orit Wasserman
2012-03-05 10:03 ` [Qemu-devel] [PATCH v2 4/9] net: use tcp_client_start for tcp client creation Amos Kong
2012-03-05 13:39   ` Orit Wasserman
2012-03-05 10:03 ` [Qemu-devel] [PATCH v2 5/9] net: refector tcp_*_start functions Amos Kong
2012-03-05 10:04 ` [Qemu-devel] [PATCH v2 6/9] net: use getaddrinfo() in tcp_start_common Amos Kong
2012-03-05 10:04 ` [Qemu-devel] [PATCH v2 7/9] net: introduce parse_host_port_info() Amos Kong
2012-03-05 10:04 ` [Qemu-devel] [PATCH v2 8/9] net: split hostname and service by last colon Amos Kong
2012-03-05 10:04 ` Amos Kong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120305100432.3595.19757.stgit@dhcp-8-167.nay.redhat.com \
    --to=akong@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=jasowang@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=laine@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).