From: Stefan Hajnoczi <stefanha@gmail.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] vnc: Fix packed boolean struct members
Date: Mon, 5 Mar 2012 13:15:02 +0000 [thread overview]
Message-ID: <20120305131502.GE28506@stefanha-thinkpad.localdomain> (raw)
In-Reply-To: <1330176948-14379-1-git-send-email-sw@weilnetz.de>
On Sat, Feb 25, 2012 at 02:35:47PM +0100, Stefan Weil wrote:
> This patch fixes warnings reported by splint:
>
> For variables which are packed in a single bit, a signed data type
> like 'int' does not make much sense.
>
> There is no obvious reason why the two values should be packed,
> so I removed the packing and changed the data type to bool
> because both are used as boolean values.
>
> Cc: Anthony Liguori <aliguori@us.ibm.com>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> ui/vnc-auth-sasl.h | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Stefan
next prev parent reply other threads:[~2012-03-05 13:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-25 13:35 [Qemu-devel] [PATCH] vnc: Fix packed boolean struct members Stefan Weil
2012-03-05 13:15 ` Stefan Hajnoczi [this message]
2012-03-08 15:26 ` Stefan Hajnoczi
2012-03-08 16:08 ` Paolo Bonzini
2012-03-08 16:25 ` Anthony Liguori
2012-03-08 18:07 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120305131502.GE28506@stefanha-thinkpad.localdomain \
--to=stefanha@gmail.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).