From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56097) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S4XlA-0004to-Jx for qemu-devel@nongnu.org; Mon, 05 Mar 2012 08:15:30 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S4Xl4-0007iX-Bh for qemu-devel@nongnu.org; Mon, 05 Mar 2012 08:15:28 -0500 Date: Mon, 5 Mar 2012 13:15:02 +0000 From: Stefan Hajnoczi Message-ID: <20120305131502.GE28506@stefanha-thinkpad.localdomain> References: <1330176948-14379-1-git-send-email-sw@weilnetz.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1330176948-14379-1-git-send-email-sw@weilnetz.de> Subject: Re: [Qemu-devel] [PATCH] vnc: Fix packed boolean struct members List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: QEMU Trivial , Anthony Liguori , qemu-devel@nongnu.org On Sat, Feb 25, 2012 at 02:35:47PM +0100, Stefan Weil wrote: > This patch fixes warnings reported by splint: > > For variables which are packed in a single bit, a signed data type > like 'int' does not make much sense. > > There is no obvious reason why the two values should be packed, > so I removed the packing and changed the data type to bool > because both are used as boolean values. > > Cc: Anthony Liguori > Signed-off-by: Stefan Weil > --- > ui/vnc-auth-sasl.h | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) Thanks, applied to the trivial patches tree: https://github.com/stefanha/qemu/commits/trivial-patches Stefan